Fixes styling for hidden element#4158
Merged
luacmartins merged 1 commit intoExpensify:mainfrom Jul 22, 2021
rdjuric:fixHiddenStyling
Merged
Fixes styling for hidden element#4158luacmartins merged 1 commit intoExpensify:mainfrom rdjuric:fixHiddenStyling
luacmartins merged 1 commit intoExpensify:mainfrom
rdjuric:fixHiddenStyling
Conversation
luacmartins
requested changes
Jul 21, 2021
Contributor
luacmartins
left a comment
luacmartins
left a comment
There was a problem hiding this comment.
Code LGTM. Can we add screenshots/videos for all platforms to make sure there is no regression?
Contributor
Author
|
Updated the PR with videos for all platforms @luacmartins |
luacmartins
approved these changes
Jul 22, 2021
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
60 tasks
Contributor
|
🚀 Deployed to staging in version: 1.0.79-5🚀
|
Contributor
|
🚀 Deployed to production in version: 1.0.80-2🚀
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
hiddenElementOutsideOfWindowto be cross-platform.Textout of theViewthat wrapsTextInputAutoWidthso that ourposition: absoluteis in relation to the parent component.Fixed Issues
$ #3296
$ #3355
Tests
QA Steps
Tested On
Screenshots
Web
web.mov
Mobile Web
mWeb.mp4
Desktop
desktop.mov
iOS
iOS-iPhone.mp4
aaaaa.mov
Android
ANdroid.mp4