Center new expensify icon in about page#4180
Merged
jasperhuangg merged 2 commits intoExpensify:mainfrom Jul 23, 2021
Merged
Conversation
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Contributor
Author
jasperhuangg
approved these changes
Jul 23, 2021
Contributor
jasperhuangg
left a comment
There was a problem hiding this comment.
Code LGTM! I'm going to wait on the tests to run and approval from @shawnborton on the new screenshots you've posted before merging 👍
Contributor
|
Looks good to me! |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
60 tasks
Contributor
|
🚀 Deployed to staging in version: 1.0.79-5🚀
|
5 tasks
Contributor
|
I believe this PR caused a regression, reverting... |
Contributor
|
JK, I didn't revert this. @helaoutar fixed the regression in this PR |
Contributor
|
🚀 Deployed to production in version: 1.0.80-2🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Details
The PR aims to center the Expensify icon in about page
Fixed Issues
Fixes #4119
Tests
QA Steps
Simply make sure that the icon is centered in about page, on Web/Mobile Web/ Desktop/ iOS and Android.
Tested On
Screenshots
Mobile Web
Web
Desktop
iOS
Android