Include an add workspace button when selecting participants by allroundexperts · Pull Request #41811 · Expensify/App

allroundexperts · 2024-05-07T20:17:39Z

Details

Details: #40823

Fixed Issues

$ #40823
PROPOSAL: N/A

Tests

Pre-Req: Make sure that you have a existing workspace on your account.

Click on the Fab, then track expense and create a track expense request
Actionable whispers should appear in personal chat
Click on the Categorize option.
Verify that a create new workspace button shows up in the workspace selection page.
Click on the button and verify that select a category appears and selecting it creates a request successfully.

Repeat steps 1-2, and click on the Share with accountant whisper
Verify that you are redirected to the request confirmation page and upon confirmation, you're able to see an invite members page.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Pre-Req: Make sure that you have a existing workspace on your account.

Click on the Fab, then track expense and create a track expense request
Actionable whispers should appear in personal chat
Click on the Categorize option.
Verify that a create new workspace button shows up in the workspace selection page.
Click on the button and verify that select a category appears and selecting it creates a request successfully.

Repeat steps 1-2, and click on the Share with accountant whisper
Verify that you are redirected to the request confirmation page and upon confirmation, you're able to see an invite members page.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-08.at.1.01.43.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-05-08.at.1.03.55.AM.mov

iOS: Native

Screen.Recording.2024-05-08.at.1.05.20.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-05-08.at.1.09.27.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-08.at.12.58.53.AM.mov

MacOS: Desktop

Screen.Recording.2024-05-08.at.12.56.27.AM.mov

melvin-bot · 2024-05-07T20:17:45Z

@shawnborton @ishpaul777 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-05-07T20:59:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-10.at.12.50.12.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-05-10.at.12.52.46.AM.mov

iOS: Native

Screen.Recording.2024-05-10.at.12.39.08.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-05-10.at.12.41.01.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-10.at.12.34.38.AM.mov

MacOS: Desktop

Screen.Recording.2024-05-10.at.12.58.45.AM.mov

ishpaul777 · 2024-05-07T21:18:16Z

Related to #41465, just curious why cant we have the new workspace name to be in same pattern we have "username's Workspace" ?

@allroundexperts

allroundexperts · 2024-05-07T21:34:00Z

Related to #41465, just curious why cant we have the new workspace name to be in same pattern we have "username's Workspace" ?
@allroundexperts

@ishpaul777 This gets set when the response from the server comes back. For the optimistic case, it's like you have suggested. @thienlnam already has an internal issue for handling this 😄

ishpaul777 · 2024-05-07T21:42:40Z

ah sorry i didn't noticed that i just assumed we set it this way

ishpaul777 · 2024-05-07T21:46:27Z

bug: share to accountant flow seems broken after click "new workspace"

Screen.Recording.2024-05-08.at.3.13.20.AM.mov

ishpaul777 · 2024-05-07T21:56:51Z

I will resume this tomorrow, have to go offline for the night 💤

shawnborton · 2024-05-08T01:57:02Z

The screenshots in the original comment look pretty good to me.

ishpaul777 · 2024-05-08T19:05:21Z

@allroundexperts did you get a chance to look into #41811 (comment)

allroundexperts · 2024-05-09T08:24:39Z

@ishpaul777 Fixed.

Screen.Recording.2024-05-09.at.1.23.56.PM.mov

ishpaul777 · 2024-05-09T19:00:04Z

src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

+                    <Button
+                        success
+                        text={translate('workspace.new.newWorkspace')}
+                        onPress={() => onFinish()}


Suggested change

onPress={() => onFinish()}

onPress={onFinish}

ishpaul777

Just minor comment. Rest looks Great!

thienlnam · 2024-05-13T17:23:05Z

Looks good, just one merge conflict now!

allroundexperts · 2024-05-14T18:45:39Z

@thienlnam Ready.

OSBotify · 2024-05-14T19:14:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-15T10:14:39Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.74-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-22T23:59:39Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.74-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

include an add workspace button when selecting participants

1830427

allroundexperts requested a review from a team as a code owner May 7, 2024 20:17

melvin-bot bot requested review from ishpaul777 and shawnborton and removed request for a team May 7, 2024 20:17

allroundexperts mentioned this pull request May 7, 2024

[hold for payment 2024-05-29] CRITICAL [$500] Provide option to create workspace on workspace selector screen for Categorize and Share #40823

Closed

allroundexperts changed the title ~~include an add workspace button when selecting participants~~ Include an add workspace button when selecting participants May 7, 2024

add missing commit

04fc1b8

Merge branch 'main' into feat-40823

4c562bd

create draft workspace for share action

3f4c6d4

ishpaul777 reviewed May 9, 2024

View reviewed changes

ishpaul777 approved these changes May 9, 2024

View reviewed changes

melvin-bot bot requested a review from thienlnam May 9, 2024 19:33

Merge branch 'main' into feat-40823

8da90c7

thienlnam approved these changes May 14, 2024

View reviewed changes

thienlnam merged commit 27a1e83 into Expensify:main May 14, 2024

github-actions bot mentioned this pull request May 15, 2024

Deploy Checklist: New Expensify 2024-05-15 #42185

Closed

Conversation

allroundexperts commented May 7, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 7, 2024

Uh oh!

ishpaul777 commented May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ishpaul777 commented May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allroundexperts commented May 7, 2024

Uh oh!

ishpaul777 commented May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented May 7, 2024

Uh oh!

shawnborton commented May 8, 2024

Uh oh!

ishpaul777 commented May 8, 2024

Uh oh!

allroundexperts commented May 9, 2024

Uh oh!

ishpaul777 May 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ishpaul777 left a comment

Choose a reason for hiding this comment

Uh oh!

thienlnam commented May 13, 2024

Uh oh!

allroundexperts commented May 14, 2024

Uh oh!

OSBotify commented May 14, 2024

Uh oh!

OSBotify commented May 15, 2024

Uh oh!

OSBotify commented May 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ishpaul777 commented May 7, 2024 •

edited

Loading

ishpaul777 commented May 7, 2024 •

edited

Loading

ishpaul777 commented May 7, 2024 •

edited

Loading

ishpaul777 commented May 7, 2024 •

edited

Loading

ishpaul777 May 9, 2024 •

edited

Loading