Implement offline behavior and error handling for UpdateGroupChatName by nkdengineer · Pull Request #41826 · Expensify/App

nkdengineer · 2024-05-08T08:36:00Z

Details

Fixed Issues

$ #39984
PROPOSAL: #39984 (comment)

Tests

Create a group
Go to force offline mode
Try to edit group name with invalid name (example: adoadoadoajdoajdoadoajdoajadoadoadoajdoajdoadoajdoajadoadoadoajdoajdoadoajdoajadoadoadoajdoajdoadoaỏ)
Verify that: group name in Settings is grayed out
Back to online mode
Verify that: group name returns back and error message appears

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create a group
Go to force offline mode
Try to edit group name with invalid name (example: adoadoadoajdoajdoadoajdoajadoadoadoajdoajdoadoajdoajadoadoadoajdoajdoadoajdoajadoadoadoajdoajdoadoaỏ)
Verify that: group name in Settings is grayed out
Back to online mode
Verify that: group name returns back and error message appears

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-resize.mp4

Android: mWeb Chrome

android-mweb-resize.mp4

iOS: Native

ios-resize.mp4

iOS: mWeb Safari

ios-mweb-resize.mp4

MacOS: Chrome / Safari

web-resize.mp4

MacOS: Desktop

desktop.mov

…pChatName

melvin-bot · 2024-05-08T09:03:04Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/actions/Report.ts

dannymcclain · 2024-05-09T13:59:49Z

This is working and looking pretty good to me. Are you using our standard error component for the error? The dot looks a little far away from the text to me.

Looks like it's 12px in the code, but in Figma I'm seeing it as 8px. @Expensify/design for a gut check on that. Could definitely be that we updated that spacing in Figma for the error but never updated it in the product.

shawnborton · 2024-05-09T14:17:23Z

Hmm yeah, it does feel a bit far away - I wonder if we can just make the global change to match what we have in Figma, which sounds like is the gap value (8px) we'd expect for these?

dannymcclain · 2024-05-09T15:20:17Z

I wonder if we can just make the global change to match what we have in Figma

Yeah that would be ideal—I feel like this one comes up quite a bit.

s77rt · 2024-05-09T18:21:46Z

The error design is being refactored here #41670

nkdengineer · 2024-05-13T03:00:40Z

@s77rt @dukenv0307 i updated code, please check again 🙏

s77rt

Can you also please check #39984 (comment) and #39984 (comment)?

src/libs/actions/Report.ts

s77rt · 2024-05-13T07:25:34Z

src/libs/actions/Report.ts

+            value: {
+                reportName: currentReportData?.[reportID]?.reportName,
+                errors: {
+                    reportName: Localize.translateLocal('groupChat.invalidGroupChatName'),


NAB. I think we want to use a generic error message

Yes, let's use the generic message as we already discussed here

@s77rt @dukenv0307 i added new generic error, please check again

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

nkdengineer · 2024-05-14T03:59:24Z

@s77rt I modified function isValidReportName function to be in sync with prop maxLength

s77rt · 2024-05-14T08:30:27Z

src/languages/en.ts

+        invalidGroupChatName: 'Invalid group chat name',
+        genericErrorMessage: 'An error occurred while updating group chat name, please try again.',


Remove the translations, not needed

s77rt · 2024-05-14T08:31:06Z

src/libs/ValidationUtils.ts


 function isValidReportName(name: string) {
-    return name.trim().length < CONST.REPORT_NAME_LIMIT;
+    return name.trim().length <= CONST.REPORT_NAME_LIMIT;


Update CONST.REPORT_NAME_LIMIT check #39984 (comment)

src/libs/actions/Report.ts

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

nkdengineer · 2024-05-15T03:35:37Z

@s77rt @dukenv0307 please check again

s77rt · 2024-05-15T15:53:34Z

Code looks good to me 👍

dukenv0307 · 2024-05-16T03:35:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

web-resize.mp4

Android: mWeb Chrome

web-resize.mp4

iOS: Native

web-resize.mp4

iOS: mWeb Safari

web-resize.mp4

MacOS: Chrome / Safari

web-resize.mp4

MacOS: Desktop

web-resize.mp4

dukenv0307 · 2024-05-16T03:44:31Z

@nkdengineer Can you add the example for invalid name in test steps? Thanks

nkdengineer · 2024-05-16T03:53:00Z

@dukenv0307 please check again

dukenv0307 · 2024-05-16T04:15:38Z

code looks good and tests well

nkdengineer · 2024-05-23T08:01:08Z

@marcaaron Please help to review the PR when you have a chance.

marcaaron

LGTM

OSBotify · 2024-05-29T09:42:24Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.4.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T21:25:13Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T22:37:11Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rojiphil · 2024-08-04T15:22:17Z

src/libs/actions/Report.ts

+            key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
+            value: {
+                reportName: currentReportData?.[reportID]?.reportName ?? null,
+                errors: {


Capturing error should be based on errorFields but since we depended on errors this resulted in issue #42765

feature: Implement offline behavior and error handling for UpdateGrou…

2f7103a

…pChatName

nkdengineer marked this pull request as ready for review May 8, 2024 09:02

nkdengineer requested a review from a team as a code owner May 8, 2024 09:03

melvin-bot bot requested review from dukenv0307 and removed request for a team May 8, 2024 09:03

nkdengineer mentioned this pull request May 9, 2024

[HOLD for payment 2024-06-06] [$250] Implement offline behavior and error handling for UpdateGroupChatName #39984

Closed

s77rt suggested changes May 9, 2024

View reviewed changes

src/libs/actions/Report.ts Show resolved Hide resolved

src/libs/actions/Report.ts Show resolved Hide resolved

src/libs/actions/Report.ts Outdated Show resolved Hide resolved

update logic update group chat name

084e45e

s77rt suggested changes May 13, 2024

View reviewed changes

nkdengineer and others added 3 commits May 14, 2024 10:15

Update src/libs/actions/Report.ts

b9a0c25

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

add new error

c91742f

fix: logic check is valid report name

a102435

s77rt suggested changes May 14, 2024

View reviewed changes

nkdengineer and others added 2 commits May 15, 2024 10:28

Update src/libs/actions/Report.ts

02f9472

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

fix: update group name limit

320cb6e

Merge branch 'main' into fix/39984

3bf2763

dukenv0307 approved these changes May 16, 2024

View reviewed changes

melvin-bot bot requested a review from marcaaron May 16, 2024 04:15

s77rt mentioned this pull request May 19, 2024

Combine report name routes #42369

Merged

50 tasks

marcaaron approved these changes May 28, 2024

View reviewed changes

marcaaron assigned dukenv0307 and nkdengineer and unassigned dukenv0307 May 28, 2024

marcaaron merged commit 5c80742 into Expensify:main May 28, 2024

github-actions bot mentioned this pull request May 29, 2024

Deploy Checklist: New Expensify 2024-05-29 #42741

Closed

lanitochka17 mentioned this pull request May 29, 2024

[$250] [HOLD for payment 2024-08-01] Group name - RBR doesn't disappear from LHN after removing error message #42765

Closed

6 tasks

rojiphil reviewed Aug 4, 2024

View reviewed changes

		invalidGroupChatName: 'Invalid group chat name',
		genericErrorMessage: 'An error occurred while updating group chat name, please try again.',

Conversation

nkdengineer commented May 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 8, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dannymcclain commented May 9, 2024

Uh oh!

shawnborton commented May 9, 2024

Uh oh!

dannymcclain commented May 9, 2024

Uh oh!

s77rt commented May 9, 2024

Uh oh!

nkdengineer commented May 13, 2024

Uh oh!

s77rt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

s77rt May 13, 2024

Choose a reason for hiding this comment

Uh oh!

dukenv0307 May 13, 2024

Choose a reason for hiding this comment

Uh oh!

nkdengineer May 14, 2024

Choose a reason for hiding this comment

Uh oh!

nkdengineer commented May 14, 2024

Uh oh!

s77rt May 14, 2024

Choose a reason for hiding this comment

Uh oh!

s77rt May 14, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nkdengineer commented May 15, 2024

Uh oh!

s77rt commented May 15, 2024

Uh oh!

dukenv0307 commented May 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented May 16, 2024

Uh oh!

nkdengineer commented May 16, 2024

Uh oh!

dukenv0307 commented May 16, 2024

Uh oh!

nkdengineer commented May 23, 2024

Uh oh!

marcaaron left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 29, 2024

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

rojiphil Aug 4, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

nkdengineer commented May 8, 2024 •

edited

Loading

dukenv0307 commented May 16, 2024 •

edited

Loading