fix message after deleting self mention displays green dot in LHN by tienifr · Pull Request #41888 · Expensify/App

tienifr · 2024-05-09T09:46:43Z

Details

Fixed Issues

$ #40469
PROPOSAL: #40469 (comment)

Tests

Go to app
Open self DM report
Mention self and send it
Send another message
Delete the previous DM message
Navigate to LHN
Long press the report in LHN and select mark as unread
Verify mark as unread a message after deleting self mention must not display green dot in LHN.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to app
Open self DM report
Mention self and send it
Send another message
Delete the previous DM message
Navigate to LHN
Long press the report in LHN and select mark as unread
Verify mark as unread a message after deleting self mention must not display green dot in LHN.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-09.at.17.50.42.mov

Android: mWeb Chrome

Screen.Recording.2024-05-09.at.17.39.16.mov

iOS: Native

Screen.Recording.2024-05-14.at.03.53.08.mov

iOS: mWeb Safari

Screen.Recording.2024-05-09.at.17.37.25.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-09.at.17.26.07.mov

MacOS: Desktop

Screen.Recording.2024-05-09.at.17.34.53.mov

melvin-bot · 2024-05-09T10:53:04Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2024-05-11T08:13:52Z

@tienifr You missed the iOS video in your checklist, also while testing ios, mark as unread didn't work for selfDM

Screen.Recording.2024-05-11.at.15.10.59.mov

tienifr · 2024-05-13T20:56:10Z

@hungvu193 Sorry. I just added the ios recording in PR author`s checklist.

tienifr · 2024-05-13T21:03:57Z

mark as unread didn't work for selfDM

I can reproduce it in all platform but the same issue is encountered in latest main. I am still investigating it.

tienifr · 2024-05-20T02:48:14Z

@hungvu193 Pls help review the PR once you have a chance

hungvu193 · 2024-05-20T02:49:54Z

@hungvu193 Pls help review the PR once you have a chance

Sure. Can you merge main please?

hungvu193 · 2024-05-20T03:57:15Z

I took a test and it doesn't work, can you take a look @tienifr ?

Screen.Recording.2024-05-20.at.10.56.25.mov

tienifr · 2024-05-21T11:19:26Z

@hungvu193 Can you test on a new account (or any selfDM that does not have self mention message before) to make sure it works properly. I tried on a new account and it works well.

Screen.Recording.2024-05-21.at.18.17.11.mov

hungvu193 · 2024-05-21T11:21:35Z

I actually tested on a new account. But let me test again

hungvu193 · 2024-05-22T02:54:56Z

Here's the brand new account and I can still reproduce. You need to repeat these steps few times:

Mention self and send it
Send another message
Delete the previous DM message
Navigate to LHN
Long press the report in LHN and select mark as unread
Reload the page

Screen.Recording.2024-05-22.at.09.52.30.mov

hungvu193 · 2024-05-24T02:29:16Z

any update here @tienifr

tienifr · 2024-05-24T02:30:59Z

@hungvu193 I am still investigating because the bug is inconsistency when reproducing from my side

hungvu193 · 2024-05-24T04:28:00Z

Thanks for your update. Please keep me posted

tienifr · 2024-05-24T08:56:41Z

@hungvu193 The RCA of this bug is: Currently, from FE, we reset the lastMentionedTime to null if we delete the self-mention message and there's no such mention report action but BE does not.

So we need the change from BE as well. cc @neil-marcellini

hungvu193 · 2024-05-29T02:09:13Z

@tienifr We have some conflicts here

tienifr · 2024-05-29T21:55:21Z

@hungvu193 I think we should wait until BE is fixed, then I will merge main and retest again.

hungvu193 · 2024-05-29T23:21:57Z

Yeah agreed

tienifr · 2024-07-11T22:17:28Z

Ah, PR is ready to review @hungvu193

hungvu193 · 2024-07-12T07:31:11Z

I did few tests and I think t still can reproduce the issue:

Screen.Recording.2024-07-12.at.14.29.47.mov

neil-marcellini

The code is looking good now, thank you

neil-marcellini · 2024-07-15T16:49:13Z

Bump @tienifr to fix a bug

tienifr · 2024-07-15T16:52:17Z

I did few tests and I think t still can reproduce the issue:

@hungvu193 Can you give me the test steps to reproduce this bug? I cannot reproduce with the test steps in the author PR checklist from my side.

hungvu193 · 2024-07-15T23:37:26Z

I did few tests and I think t still can reproduce the issue:

@hungvu193 Can you give me the test steps to reproduce this bug? I cannot reproduce with the test steps in the author PR checklist from my side.

You can just reload the page after mark as read and repeat few times

hungvu193 · 2024-07-17T02:06:41Z

@tienifr I still can reproduce, do you get any issue to reproduce it? Let's me know

tienifr · 2024-07-17T13:19:29Z

You can just reload the page after mark as read and repeat few times

@hungvu193 I can reproduce it. Before reloading the page, it works properly and the report does not have lastMentionedTime value. But after reloading, BE returns the report with the lastMentionedTime. I think it is BE issue. cc @neil-marcellini

neil-marcellini · 2024-07-17T19:35:01Z

@hungvu193 as explained here we can't really fix the backend without a huge amount of effort, so we're going to have to live with that backend related bug.

@tienifr please fix conflicts, then @hungvu193 please complete the reviewer checklist and hopefully we can merge.

tienifr · 2024-07-18T15:59:23Z

I merged main

hungvu193 · 2024-07-19T04:10:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-19.at.13.31.34.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-07-19.at.10.46.11.mov

iOS: mWeb Safari

Screen.Recording.2024-07-19.at.11.10.18.mov

MacOS: Chrome / Safari

Chrome.mov

MacOS: Desktop

Screen.Recording.2024-07-19.at.10.30.33.mov

hungvu193

All yours @neil-marcellini

hungvu193 · 2024-07-23T03:04:00Z

little bump @neil-marcellini

neil-marcellini · 2024-07-23T19:08:18Z

Sorry for the delay, I was out of office. Merging now! Finally haha.

OSBotify · 2024-07-23T19:19:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-25T03:37:35Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hungvu193 · 2024-07-25T06:48:12Z

For the QA that test this PR, please take a look at this comment.

kavimuru · 2024-07-25T19:38:47Z

Failing in web and mweb

https://platform.applause.com/services/links/v1/external/2aa22005704a95df1a883d4f1572d846cec56e5543d695252acc8fc070772820
https://platform.utest.com/services/links/v1/internal/52537032?.mp4

francoisl · 2024-07-26T04:34:17Z

@neil-marcellini is this due to what you were saying in this comment? I'm not going to block the deploy on this for now but let's double-check if anything isn't working as expected here. Thanks!

OSBotify · 2024-07-26T05:12:40Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-26T05:35:47Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.13-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

eh2077 · 2025-03-16T14:14:09Z

src/libs/actions/Report.ts

+    if (didCommentMentionCurrentUser && reportAction.created === report?.lastMentionedTime) {
+        const reportActionsForReport = allReportActions?.[reportID];
+        const latestMentioneReportAction = Object.values(reportActionsForReport ?? {}).find(
+            (action) => action.reportActionID !== reportAction.reportActionID && ReportActionsUtils.didMessageMentionCurrentUser(action),


This line caused

[Due for payment 2025-03-17] [$250] Web - LHN - Mark as unread a message after deleting self mention displays green dot in LHN #57205

The latest mentioned report action should be visible

tienifr added 2 commits May 9, 2024 16:43

fix message after deleting self mention displays green dot in LHN

871980e

fix lint

3780692

tienifr marked this pull request as ready for review May 9, 2024 10:53

tienifr requested a review from a team as a code owner May 9, 2024 10:53

melvin-bot bot removed the request for review from a team May 9, 2024 10:53

melvin-bot bot requested a review from hungvu193 May 9, 2024 10:53

tienifr mentioned this pull request May 9, 2024

[HOLD for payment 2024-08-02] [$250] mweb-LHN-Mark as unread a message after deleting self mention displays green dot in LHN. #40469

Closed

6 tasks

fix merge main

458c472

fix merge main

864f25d

fix merge main

4f50e33

neil-marcellini and others added 3 commits June 6, 2024 17:22

Merge branch 'main' into fix/40469

b1602f6

fix merge main

49787d3

fix lint

6aaa641

neil-marcellini previously approved these changes Jul 12, 2024

View reviewed changes

merge main

2155745

fix conflict

8f88a88

tienifr dismissed neil-marcellini’s stale review via 8f88a88 July 18, 2024 15:27

hungvu193 approved these changes Jul 19, 2024

View reviewed changes

melvin-bot bot requested a review from neil-marcellini July 19, 2024 04:11

neil-marcellini approved these changes Jul 23, 2024

View reviewed changes

neil-marcellini merged commit 91a5c69 into Expensify:main Jul 23, 2024

This was referenced Jul 23, 2024

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #46076

Closed

Deploy Checklist: New Expensify 2024-07-25 #46161

Closed

eh2077 reviewed Mar 16, 2025

View reviewed changes

Conversation

tienifr commented May 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 9, 2024

Uh oh!

hungvu193 commented May 11, 2024

Uh oh!

tienifr commented May 13, 2024

Uh oh!

tienifr commented May 13, 2024

Uh oh!

tienifr commented May 20, 2024

Uh oh!

hungvu193 commented May 20, 2024

Uh oh!

hungvu193 commented May 20, 2024

Uh oh!

tienifr commented May 21, 2024

Uh oh!

hungvu193 commented May 21, 2024

Uh oh!

hungvu193 commented May 22, 2024

Uh oh!

hungvu193 commented May 24, 2024

Uh oh!

tienifr commented May 24, 2024

Uh oh!

hungvu193 commented May 24, 2024

Uh oh!

tienifr commented May 24, 2024

Uh oh!

hungvu193 commented May 29, 2024

Uh oh!

tienifr commented May 29, 2024

Uh oh!

hungvu193 commented May 29, 2024

Uh oh!

tienifr commented Jul 11, 2024

Uh oh!

hungvu193 commented Jul 12, 2024

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini commented Jul 15, 2024

Uh oh!

tienifr commented Jul 15, 2024

Uh oh!

hungvu193 commented Jul 15, 2024

Uh oh!

hungvu193 commented Jul 17, 2024

Uh oh!

tienifr commented Jul 17, 2024

Uh oh!

neil-marcellini commented Jul 17, 2024

Uh oh!

tienifr commented Jul 18, 2024

Uh oh!

hungvu193 commented Jul 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Jul 23, 2024

Uh oh!

neil-marcellini commented Jul 23, 2024

Uh oh!

OSBotify commented Jul 23, 2024

Uh oh!

tienifr commented May 9, 2024 •

edited

Loading

hungvu193 commented Jul 19, 2024 •

edited

Loading