Dont create multiple policy by cretadn22 · Pull Request #41990 · Expensify/App

cretadn22 · 2024-05-10T17:27:04Z

Details

Call UpdateWorkspaceGeneralSettings with the new name if the user navigated back and then forward again

Fixed Issues

$ #41838
PROPOSAL: #41838 (comment)

Tests

Sign up with a new account
Click Manage my team's Expenses in the onboarding modal
Verify that the next question you're asked is for your business name
Enter your business name
Verify that the next question you're asked is for your personal name
Click back button and change business name
Verify that the initial workspace change the name instead of creating new workspace

Verify that no errors appear in the JS console

Offline tests

Can't test offline

QA Steps

Sign up with a new account
Click Manage my team's Expenses in the onboarding modal
Verify that the next question you're asked is for your business name
Enter your business name
Verify that the next question you're asked is for your personal name
Click back button and change business name
Verify that the initial workspace change the name instead of creating new workspace

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-11.at.10.39.21.mov

Android: mWeb Chrome

Screen.Recording.2024-05-11.at.10.37.41.mov

iOS: Native

Screen.Recording.2024-05-11.at.10.38.25.mov

iOS: mWeb Safari

Screen.Recording.2024-05-11.at.10.34.35.mov

MacOS: Chrome / Safari

2.mp4

MacOS: Desktop

1.mov

melvin-bot · 2024-05-10T17:27:09Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cretadn22 · 2024-05-10T17:47:18Z

src/pages/OnboardingWork/BaseOnboardingWork.tsx

Using this comment to fix the lint error like other places

cretadn22 · 2024-05-10T17:48:18Z

src/pages/OnboardingWork/BaseOnboardingWork.tsx

Using "CONST.CURRENCY.USD" because this value always be returned from BE when creating workspace

cretadn22 · 2024-05-14T14:44:09Z

@ishpaul777 The PR is ready

ishpaul777 · 2024-05-14T16:39:31Z

will review today : )

ishpaul777 · 2024-05-14T19:30:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Record_2024-05-15-00-57-54.mp4

Android: mWeb Chrome

Record_2024-05-15-01-04-52.mp4

iOS: Native

Screen.Recording.2024-05-15.at.12.38.55.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-05-15.at.12.26.21.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-15.at.12.22.04.AM.mov

MacOS: Desktop

Screen.Recording.2024-05-15.at.1.10.11.AM.mov

ishpaul777 · 2024-05-14T19:43:48Z

@cretadn22 Please merge main

cretadn22 · 2024-05-15T00:40:50Z

@ishpaul777 Updated latest main

cretadn22 · 2024-05-15T14:13:24Z

@ishpaul777 How can we proceed from this point onward?

ishpaul777

LGTM!

src/pages/OnboardingWork/BaseOnboardingWork.tsx

cretadn22 · 2024-05-15T17:24:20Z

The lint error is so weird

cretadn22 · 2024-05-15T17:37:55Z

@francoisl I removed the assertion to fix lint error. Everything is ready to merge

francoisl

👍

OSBotify · 2024-05-15T18:31:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-23T00:39:48Z

🚀 Deployed to staging by https://github.com/francoisl in version: 1.4.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-27T14:02:56Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.75-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

s77rt · 2025-07-23T09:57:24Z

src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx

            );

            Welcome.setOnboardingAdminsChatReportID();
+            Welcome.setOnboardingPolicyID();


@cretadn22 Do you recall why or if this clean up is necessary? Or was it done just for consistency with setOnboardingAdminsChatReportID?

Yes, that's correct, if I’m recalling correctly.

cretadn22 requested a review from a team as a code owner May 10, 2024 17:27

melvin-bot bot removed the request for review from a team May 10, 2024 17:27

melvin-bot bot requested a review from ishpaul777 May 10, 2024 17:27

cretadn22 force-pushed the dont-create-multiple-policy branch from d39f389 to a139da7 Compare May 10, 2024 17:30

cretadn22 commented May 10, 2024

View reviewed changes

cretadn22 marked this pull request as draft May 10, 2024 18:48

update the initial policy instead of creating multiple policies

df94ad0

cretadn22 force-pushed the dont-create-multiple-policy branch from c73e06e to df94ad0 Compare May 11, 2024 03:32

cretadn22 marked this pull request as ready for review May 11, 2024 03:49

update latest main

0fdde60

ishpaul777 approved these changes May 15, 2024

View reviewed changes

melvin-bot bot requested a review from francoisl May 15, 2024 15:46

francoisl reviewed May 15, 2024

View reviewed changes

src/pages/OnboardingWork/BaseOnboardingWork.tsx Outdated Show resolved Hide resolved

using else statement

d86a856

francoisl previously approved these changes May 15, 2024

View reviewed changes

fix the lint error

5f8e897

cretadn22 dismissed francoisl’s stale review via 5f8e897 May 15, 2024 17:27

francoisl approved these changes May 15, 2024

View reviewed changes

francoisl merged commit 82bacc9 into Expensify:main May 15, 2024

github-actions bot mentioned this pull request May 22, 2024

Deploy Checklist: New Expensify 2024-05-22 #42496

Closed

45 tasks

melvin-bot bot mentioned this pull request May 27, 2024

[$250] [HOLD for payment 2024-06-03] [Guided Setup Stage 2] Multiple workspaces are created when navigating back and changing the business name #41838

Closed

6 tasks

s77rt reviewed Jul 23, 2025

View reviewed changes

s77rt mentioned this pull request Jul 23, 2025

[$250] [EX-43] - Onboarding - User should be redirected to #admins after taking a test drive #65274

Closed

8 tasks

Conversation

cretadn22 commented May 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 10, 2024

Uh oh!

cretadn22 May 10, 2024

Choose a reason for hiding this comment

Uh oh!

cretadn22 May 10, 2024

Choose a reason for hiding this comment

Uh oh!

cretadn22 commented May 14, 2024

Uh oh!

ishpaul777 commented May 14, 2024

Uh oh!

ishpaul777 commented May 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ishpaul777 commented May 14, 2024

Uh oh!

cretadn22 commented May 15, 2024

Uh oh!

cretadn22 commented May 15, 2024

Uh oh!

ishpaul777 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cretadn22 commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cretadn22 commented May 15, 2024

Uh oh!

francoisl left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 15, 2024

Uh oh!

OSBotify commented May 23, 2024

Uh oh!

OSBotify commented May 27, 2024

Uh oh!

s77rt Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

cretadn22 Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cretadn22 commented May 10, 2024 •

edited

Loading

ishpaul777 commented May 14, 2024 •

edited

Loading

cretadn22 commented May 15, 2024 •

edited

Loading