feat: update ProfilePage by kosmydel · Pull Request #42188 · Expensify/App

kosmydel · 2024-05-15T12:30:43Z

Details

This PR refactors the DetailsPage component to use the new design described in the design doc.

This PR base is another PR, so to see changes only from this PR you can use this link.

Fixed Issues

$ #42077
PROPOSAL: N/A

Tests

Verify each Profile page if it works:
1. Verify the new design is displayed, and match the Figma design.
2. Verify the "Pin" button is displayed and works as expected.
3. Verify the "Message" button is displayed and works as expected.
Verify group messages:
1. Create a new group chat with a few members.
2. Send a message, and click an avatar to open the details page (your profile). Verify it works.
3. Open the group chat details (click header bar), go to Members. Select a member, click "Profile", and verify it works.
Verify DM:
1. Open a DM with a user, click the avatar/header bar to open the details page. Verify it works.
Verify public rooms:
1. Go to public chat (e.g. #exfy-roadmap: /r/868417741568295)
2. Click on the profile avatar, and verify it works.
Open public profile:
1. Go to https://dev.new.expensify.com:8082/a/1

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console
Verify tests from the Tests section.

PR Author Checklist

Screenshots/Videos

Android & iOS: Native

native.mov

Android & iOS: mWeb

mweb.mov

MacOS: Chrome / Safari

MacOS: Desktop

cdOut

LGTM 👍

melvin-bot · 2024-05-20T10:24:20Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2024-05-20T14:02:08Z

For this case here:

I feel like we should give the buttons a max-width of 50%. This way if there is just one button, it doesn't look quite as akward as this where it takes up the full width. Thoughts @Expensify/design ?

dannymcclain · 2024-05-20T14:29:30Z

I feel like we should give the buttons a max-width of 50%. This way if there is just one button, it doesn't look quite as akward as this where it takes up the full width.

Yeah I can get down with that! It does look a bit massive when it's full-width haha.

dubielzyk-expensify · 2024-05-21T01:11:47Z

I feel like we should give the buttons a max-width of 50%. This way if there is just one button, it doesn't look quite as akward as this where it takes up the full width.

Yeah that's clever and also making sure that it's centered which I'm sure it would be anyways :)

kosmydel · 2024-05-21T08:21:03Z

Thanks! I will update it in the #41972 PR, as this is where we've introduced the PromotedActionBar.

kosmydel · 2024-05-21T08:29:36Z

Done!

shawnborton · 2024-05-21T11:49:40Z

And then for posterity, can you show us what it looks like when there are 2 or more buttons here? Just to make sure we got the styles correct. Thanks!

kosmydel · 2024-05-21T14:03:43Z

And then for posterity, can you show us what it looks like when there are 2 or more buttons here? Just to make sure we got the styles correct. Thanks!

I will follow up in the original PR #41972 so as not to duplicate the discussion :D

akinwale · 2024-05-25T14:16:24Z

@kosmydel Is this PR ready for C+ review?

kosmydel · 2024-05-27T09:24:15Z

@akinwale Yes, this one is ready for initial review. Keep in mind, that this one is based on another PR which is still waiting for the merge. The changes from this particular PR are available here.

trjExpensify · 2024-05-29T21:37:58Z

here

@akinwale how are you getting on with the review? This PR has now merged: #41972

akinwale · 2024-05-30T03:31:24Z

@trjExpensify I started testing. I should be able to complete the checklist today.

@kosmydel There's a new merge conflict. Please check.

kosmydel · 2024-06-03T03:39:04Z

@kosmydel There's a new merge conflict. Please check.

I've resolved the conflicts ✅

grgia

Code changes LGTM, going to make a test build for design review

grgia · 2024-06-03T09:21:59Z

building...

github-actions · 2024-06-03T09:53:04Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/42188/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/42188/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/42188/NewExpensify.dmg	https://42188.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

akinwale · 2024-06-04T02:50:10Z

@kosmydel The Pin button on the profile page doesn't show up until after you have opened a DM with a user. Just confirming that this is the expected behaviour. Thanks.

akinwale · 2024-06-04T02:56:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

42188-web.mp4

MacOS: Desktop

akinwale

LGTM.

kosmydel · 2024-06-04T08:09:06Z

@kosmydel The Pin button on the profile page doesn't show up until after you have opened a DM with a user. Just confirming that this is the expected behaviour. Thanks.

I think it is expected, as the report doesn't exist/is not loaded until we open a DM. cc @grgia for confirmation

grgia · 2024-06-04T09:32:12Z

The Pin button on the profile page doesn't show up until after you have opened a DM with a user. Just confirming that this is the expected behaviour. Thanks.

@kosmydel @akinwale
yep, this is expected!

OSBotify · 2024-06-04T09:41:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-06T12:34:25Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ikevin127 · 2024-06-13T20:35:29Z

src/components/PromotedActionsBar.tsx

        return null;
    }

+    if (promotedActions.length === 0) {
+        return null;
+    }
+


@kosmydel Any specific reason why the additional identical early return is needed here ?

Oh, it must have been added by mistake.

feat: promoted actions in ProfilePage

6cb2ef2

kosmydel force-pushed the @kosmydel/details-revamp/profile-page branch from 6c55eb2 to 6cb2ef2 Compare May 16, 2024 05:54

kosmydel added 4 commits May 16, 2024 08:00

fix: padding

9913a2c

fix: do not display empty PromotedActionsBar

21a60ee

fix: adjust styles

95c10ea

fix: margins

49c03aa

cdOut approved these changes May 20, 2024

View reviewed changes

kosmydel marked this pull request as ready for review May 20, 2024 10:24

kosmydel requested review from a team as code owners May 20, 2024 10:24

melvin-bot bot requested review from akinwale and removed request for a team May 20, 2024 10:24

kosmydel mentioned this pull request May 20, 2024

cleanup: remove DetailsPage.tsx #42385

Merged

49 tasks

grgia self-requested a review May 20, 2024 11:45

kosmydel mentioned this pull request May 21, 2024

feat: add PromotedActionsBar #41972

Merged

50 tasks

feat: max promoted action width

af17e76

kosmydel mentioned this pull request May 29, 2024

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Details Revamp] Remove DetailsPage.tsx #42079

Closed

Merge branch 'main' into @kosmydel/details-revamp/profile-page

cb30698

grgia approved these changes Jun 3, 2024

View reviewed changes

grgia added the Ready To Build label Jun 3, 2024

Expensify deleted a comment from github-actions bot Jun 3, 2024

akinwale approved these changes Jun 4, 2024

View reviewed changes

melvin-bot bot requested a review from grgia June 4, 2024 03:16

grgia merged commit bc3009a into Expensify:main Jun 4, 2024

This was referenced Jun 4, 2024

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #43026

Closed

Deploy Checklist: New Expensify 2024-06-04 #43037

Closed

melvin-bot bot mentioned this pull request Jun 6, 2024

[$250] [HOLD for payment 2024-06-13] [Details Revamp] Update ProfilePage #42077

Closed

ikevin127 reviewed Jun 13, 2024

View reviewed changes

ikevin127 mentioned this pull request Jun 13, 2024

[Details Revamp] Update ReportDetailsPage for Rooms, Groups, Money Reports and Policy Expenses #43251

Merged

50 tasks

Conversation

kosmydel commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

cdOut left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented May 20, 2024

Uh oh!

shawnborton commented May 20, 2024

Uh oh!

dannymcclain commented May 20, 2024

Uh oh!

dubielzyk-expensify commented May 21, 2024

Uh oh!

kosmydel commented May 21, 2024

Uh oh!

kosmydel commented May 21, 2024

Uh oh!

shawnborton commented May 21, 2024

Uh oh!

kosmydel commented May 21, 2024

Uh oh!

akinwale commented May 25, 2024

Uh oh!

kosmydel commented May 27, 2024

Uh oh!

trjExpensify commented May 29, 2024

Uh oh!

akinwale commented May 30, 2024

Uh oh!

kosmydel commented Jun 3, 2024

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

grgia commented Jun 3, 2024

Uh oh!

github-actions bot commented Jun 3, 2024

Uh oh!

akinwale commented Jun 4, 2024

Uh oh!

akinwale commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

akinwale left a comment

Choose a reason for hiding this comment

Uh oh!

kosmydel commented Jun 4, 2024

Uh oh!

grgia commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Jun 4, 2024

Uh oh!

OSBotify commented Jun 6, 2024

Uh oh!

ikevin127 Jun 13, 2024

Choose a reason for hiding this comment

Uh oh!

kosmydel Jun 14, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

kosmydel commented May 15, 2024 •

edited

Loading

akinwale commented Jun 4, 2024 •

edited

Loading

grgia commented Jun 4, 2024 •

edited

Loading