[NO QA] Fix values of EXPORTED_* actions#42242
Merged
arosiclair merged 4 commits intomainfrom May 30, 2024
Merged
Conversation
|
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
50 tasks
arosiclair
requested changes
May 16, 2024
…DotReportActionName
Co-authored-by: Andrew Rosiclair <arosiclair@expensify.com>
Contributor
Author
|
Fixed @arosiclair 🙏 |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
arosiclair
approved these changes
May 16, 2024
Contributor
|
Merge freeze just hit unfortunately |
…DotReportActionName
Contributor
Author
|
@arosiclair merge freeze is off! |
Contributor
|
You can self merge too lol. I'll merge now though |
Contributor
Author
|
yeah, but free points? 🤷 |
95 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.77-11 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.77-11 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.78-5 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
During initial report action import (into App repo) looks like a few of these were messed up, understandably since the report action
Variablename is not the same as the actual string name :DFixed Issues
$ See #38013 (comment)
Tests
No manual tests needed, just verify that these report action consts do actually match the values we have in the backend
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop