Enable / Disable multi level tags by hayata-suenaga · Pull Request #42315 · Expensify/App

hayata-suenaga · 2024-05-16T18:59:08Z

Details

Fixed Issues

$ #42314
PROPOSAL: N/A

Tests / QA Steps

Enable tags on a workspace
Create several tags. Confirm that bulk enable and disable works by checking the top checkbox and clicking the Selected button.
Enable the accounting feature and connect to QBO.
Go back to the Tags screen and check that Classes and Customers/Projects are now imported as tags
Click Classes. Click the top checkbox. Click the Selected button and click Disable
Check that all tags in Classes are disabled
Do the same thing but enable tags this time. Check that all tags in Classes are enabled back.
Click Customers/Projects. Do the same thing as above. Confirm that they work.

Offline tests

Follow the same steps from Step 1 to Step 2 offline and confirm it works
Do Step 3 while the device is online
Follow Step 4 to Step 8 offline and confirm it works

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-05-16.at.11.57.38.AM.mov

MacOS: Desktop

melvin-bot · 2024-05-16T18:59:12Z

@Ollyws @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/actions/Policy.ts

s77rt · 2024-05-16T20:55:31Z

src/libs/API/parameters/SetPolicyTagsEnabled.ts

+     * When the tags are imported as multi level tags, the index of the top
+     * most tag list item
+     */
+    tagListIndex?: number;


s77rt · 2024-05-17T18:00:15Z

@hayata-suenaga Can we merge this PR first #42149? So we can cover the setWorkspaceTagEnabled call in TagSettingsPage

hayata-suenaga · 2024-05-21T00:33:05Z

Changed the base branch to the QBO freeze branch. We can merge there anytime

s77rt · 2024-05-21T00:38:06Z

Can you please fix the lint issue

hayata-suenaga · 2024-05-22T17:01:22Z

ah I didn't realize that. thank you for letting me know 😄 I'll update my PR

s77rt

Code looks good. Testing...

s77rt · 2024-05-22T17:58:49Z

tests/actions/PolicyTagTest.ts

                })
                .then(() => {
-                    Policy.setWorkspaceTagEnabled(fakePolicy.id, tagsToUpdate);
+                    Policy.setWorkspaceTagEnabled(fakePolicy.id, tagsToUpdate, fakePolicyTags[0].orderWeight);


Suggested change

Policy.setWorkspaceTagEnabled(fakePolicy.id, tagsToUpdate, fakePolicyTags[0].orderWeight);

Policy.setWorkspaceTagEnabled(fakePolicy.id, tagsToUpdate, fakePolicyTags[tagListName].orderWeight);

s77rt · 2024-05-22T17:58:57Z

tests/actions/PolicyTagTest.ts

                    mockFetch?.fail?.();

-                    Policy.setWorkspaceTagEnabled(fakePolicy.id, tagsToUpdate);
+                    Policy.setWorkspaceTagEnabled(fakePolicy.id, tagsToUpdate, fakePolicyTags[0].orderWeight);


Suggested change

Policy.setWorkspaceTagEnabled(fakePolicy.id, tagsToUpdate, fakePolicyTags[0].orderWeight);

Policy.setWorkspaceTagEnabled(fakePolicy.id, tagsToUpdate, fakePolicyTags[tagListName].orderWeight);

s77rt · 2024-05-22T18:33:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

Networking issue

iOS: Native

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

s77rt

Fix the test and

melvin-bot · 2024-05-22T18:42:32Z

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

arosiclair

Don't have much context but LGTM

…vel-tags Enable / Disable multi level tags

OSBotify · 2024-05-30T21:54:41Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T22:31:11Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2024-06-02T01:35:09Z

@hayata-suenaga #42315 failing with #42314 in desktophttps://platform.applause.com/services/links/v1/external/03a18aec5fd806bbc900f164f8aeea0f398fff1b91024577f20675ea458b776d

hayata-suenaga · 2024-06-03T14:54:50Z

@kavimuru thank you for letting me know is the issue only happening on desktop?

kavimuru · 2024-06-03T16:15:31Z

@hayata-suenaga This is happening only in desktop, retested.

Screen.Recording.2024-06-03.at.6.54.05.in.the.evening.mp4

hayata-suenaga · 2024-06-03T19:43:28Z

I believe this is a pusher related issue. will post this in Slack

hayata-suenaga · 2024-06-03T19:51:56Z

https://expensify.slack.com/archives/C036QM0SLJK/p1717443889264419?thread_ts=1717422872.999129&cid=C036QM0SLJK

OSBotify · 2024-06-04T13:57:13Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.78-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-06-06T12:34:33Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Hayata Suenaga added 3 commits May 16, 2024 11:44

feat: add new parameter to API command

bab0977

feat: pass new param to the API command

48457f2

feat: pass the index of the parent tag list item

1196025

hayata-suenaga requested a review from s77rt May 16, 2024 18:59

hayata-suenaga self-assigned this May 16, 2024

hayata-suenaga requested a review from a team as a code owner May 16, 2024 18:59

melvin-bot bot removed the request for review from a team May 16, 2024 18:59

melvin-bot bot requested a review from Ollyws May 16, 2024 18:59

s77rt suggested changes May 16, 2024

View reviewed changes

src/libs/actions/Policy.ts Outdated Show resolved Hide resolved

fix: use index to get the correct list of tags

b438c32

hayata-suenaga changed the title ~~Enable / Disable multi level tags~~ [HOLD Merge Freeze] Enable / Disable multi level tags May 16, 2024

s77rt reviewed May 16, 2024

View reviewed changes

src/libs/actions/Policy.ts Outdated Show resolved Hide resolved

s77rt reviewed May 16, 2024

View reviewed changes

Hayata Suenaga added 2 commits May 20, 2024 17:30

chore: make a prop required

611b3e5

chore: make API parameter required

a7064b4

hayata-suenaga changed the base branch from main to qbo-freeze-branch May 21, 2024 00:32

hayata-suenaga changed the title ~~[HOLD Merge Freeze] Enable / Disable multi level tags~~ Enable / Disable multi level tags May 21, 2024

hayata-suenaga requested a review from s77rt May 21, 2024 00:33

Hayata Suenaga added 3 commits May 22, 2024 10:15

fix: pass missing arguments

788f237

pass the default tag list index

e1ec259

fix: test

8ebd1a9

s77rt reviewed May 22, 2024

View reviewed changes

s77rt approved these changes May 22, 2024

View reviewed changes

melvin-bot bot requested a review from arosiclair May 22, 2024 18:42

pass default index manually

555fd58

trjExpensify removed the request for review from Ollyws May 23, 2024 10:57

lakchote approved these changes May 23, 2024

View reviewed changes

arosiclair approved these changes May 23, 2024

View reviewed changes

arosiclair merged commit f827cdb into qbo-freeze-branch May 23, 2024

arosiclair deleted the hayata-call-api-for-multi-level-tags branch May 23, 2024 16:56

lakchote pushed a commit that referenced this pull request May 23, 2024

Merge pull request #42315 from Expensify/hayata-call-api-for-multi-le…

95f1ed9

…vel-tags Enable / Disable multi level tags

github-actions bot mentioned this pull request May 30, 2024

Deploy Checklist: New Expensify 2024-05-30 #42872

Closed

95 tasks

hayata-suenaga mentioned this pull request May 31, 2024

QBO freeze branch #42543

Merged

49 tasks

carlosmiceli mentioned this pull request Jun 3, 2024

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Accounting-Renaming Customers/Projects tag doesn't work and has weird behavior while offline #42957

Closed

6 tasks

allgandalf mentioned this pull request Jun 3, 2024

[HOLD for payment 2024-06-13] [HOLD for payment 2024-06-11] [$250] Tags - Console error when disabling tag when created offline on web, app crashes on iOS #42885

Closed

6 tasks

melvin-bot bot mentioned this pull request Jun 4, 2024

[$250] [QBO] Enable and Disable multi-level tags #42314

Closed

github-actions bot mentioned this pull request Jun 4, 2024

Deploy Checklist: New Expensify 2024-06-04 #43037

Closed

	Policy.setWorkspaceTagEnabled(fakePolicy.id, tagsToUpdate, fakePolicyTags[0].orderWeight);
	Policy.setWorkspaceTagEnabled(fakePolicy.id, tagsToUpdate, fakePolicyTags[tagListName].orderWeight);

Conversation

hayata-suenaga commented May 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests / QA Steps

Offline tests

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 16, 2024

Uh oh!

Uh oh!

Uh oh!

s77rt May 16, 2024

Choose a reason for hiding this comment

Uh oh!

hayata-suenaga May 21, 2024

Choose a reason for hiding this comment

Uh oh!

s77rt commented May 17, 2024

Uh oh!

hayata-suenaga commented May 21, 2024

Uh oh!

s77rt commented May 21, 2024

Uh oh!

hayata-suenaga commented May 22, 2024

Uh oh!

s77rt left a comment

Choose a reason for hiding this comment

Uh oh!

s77rt May 22, 2024

Choose a reason for hiding this comment

Uh oh!

s77rt May 22, 2024

Choose a reason for hiding this comment

Uh oh!

s77rt commented May 22, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

s77rt left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented May 22, 2024

Uh oh!

arosiclair left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

kavimuru commented Jun 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hayata-suenaga commented Jun 3, 2024

Uh oh!

kavimuru commented Jun 3, 2024

Uh oh!

hayata-suenaga commented Jun 3, 2024

Uh oh!

hayata-suenaga commented Jun 3, 2024

Uh oh!

OSBotify commented Jun 4, 2024

Uh oh!

OSBotify commented Jun 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hayata-suenaga commented May 16, 2024 •

edited

Loading

kavimuru commented Jun 2, 2024 •

edited

Loading