[Wave Collect] [Xero] Default select options#42360
Merged
lakchote merged 9 commits intoExpensify:xero-merge-freezefrom May 21, 2024
Merged
[Wave Collect] [Xero] Default select options#42360lakchote merged 9 commits intoExpensify:xero-merge-freezefrom
lakchote merged 9 commits intoExpensify:xero-merge-freezefrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Xero Integration, some of settings didn't have default option selected. If the mappings are not set, we should be selecting the first option from the data list.
Details
Fixed Issues
$ #42378
PROPOSAL:
Tests
Pre-requisite:
Steps
Xero bank account, the first option is shown in the MenuItem. For the Demo company it'sBusiness Bank Account.Xero Bill Payment AccountandXero Invoice Collections Account.Offline tests
Same as Tests.
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-xero-default-option.mov
Android: mWeb Chrome
mweb-chrome-xero-default-option.mov
iOS: Native
ios-xero-default-option.mov
iOS: mWeb Safari
mweb-safari-xero-default-option.mov
MacOS: Chrome / Safari
web-xero-default-option.mov
MacOS: Desktop
desktop-xero-default-option.mov