fix: Can't view receipt from Split Expense details view by Krishna2323 · Pull Request #42399 · Expensify/App

Krishna2323 · 2024-05-20T18:20:21Z

Details

Fixed Issues

$ #41249
PROPOSAL: #41249 (comment)

Tests

Open a workspace
Start a split expense > scan
Upload a image/pdf receipt > confirm
Open newly created split expense from report preview
Click on the receipt image/pdf and verify the attachment opens in modal

Verify that no errors appear in the JS console

Offline tests

Open a workspace
Start a split expense > scan
Upload a image/pdf receipt > confirm
Open newly created split expense from report preview
Click on the receipt image/pdf and verify the attachment opens in modal

QA Steps

Open a workspace
Start a split expense > scan
Upload a image/pdf receipt > confirm
Open newly created split expense from report preview
Click on the receipt image/pdf and verify the attachment opens in modal

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

melvin-bot · 2024-05-20T18:20:26Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mollfpr · 2024-05-21T16:45:47Z

@Krishna2323 Let me know when the PR is ready for a review. Thanks!

Krishna2323 · 2024-05-22T14:45:07Z

Will add recording in few hours.

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 · 2024-05-23T11:06:08Z

@mollfpr, you can review the code, I couldn't add recordings yesterday as I was facing version issues in Xcode. However, I have added recording for MacOS: Chrome / Safari incase you want to check. Will add recordings today (probably in 3-4 hours) for sure.

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 · 2024-05-23T20:05:53Z

All recordings have been added.

mollfpr · 2024-05-27T16:12:43Z

src/components/MoneyRequestConfirmationList.tsx

    isEditingSplitBill?: boolean;

+    /** Whether we're shwowing a created split expense */
+    isSplitBillDetailsPage?: boolean;


I think we can make the naming more useable here, for example, shouldReceiptPressable.

What do you think about canOpenReceipt/canDIsplayReceipt?

canDIsplayReceipt sounds good to me.

updated to shouldDisplayReceipt.

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

mollfpr · 2024-05-31T11:13:51Z

src/pages/TransactionReceiptPage.tsx

    // eslint-disable-next-line rulesdir/no-negated-variables
-    const shouldShowNotFoundPage = isTrackExpenseReport ? !transaction : (moneyRequestReportID ?? '') !== transaction?.reportID;
+    const shouldShowNotFoundPage = isTrackExpenseReport || transaction?.reportID === CONST.REPORT.SPLIT_REPORTID ? !transaction : (moneyRequestReportID ?? '') !== transaction?.reportID;
+    // const shouldShowNotFoundPage = isTrackExpenseReport ? !transaction : (moneyRequestReportID ?? '') !== transaction?.reportID;


Is this change needed?

We need to modify the shouldShowNotFoundPage because the transaction?.reportID for split transaction is always -2.

I mena there's a comment in the next line.

ohh sorry, I missed that, updated now.

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

mollfpr · 2024-06-05T12:25:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

42399.Android.mp4

Android: mWeb Chrome

42399.mWeb-Chrome.mp4

iOS: Native

42399.iOS.mov

iOS: mWeb Safari

42399.mWeb-Safari.mov

MacOS: Chrome / Safari

42399.Web.mp4

MacOS: Desktop

42399.Desktop.mp4

mollfpr · 2024-06-05T17:10:33Z

@Krishna2323 Could you resolve the conflict? Thanks!

Krishna2323 · 2024-06-06T00:49:22Z

Conflicts resolved.

OSBotify · 2024-06-06T19:47:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-11T23:32:04Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: Can't view receipt from Split Expense details view

3bf0a5a

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner May 20, 2024 18:20

melvin-bot bot requested review from mollfpr and removed request for a team May 20, 2024 18:20

introduce isSplitBillDetailsPage prop in MoneyRequestConfirmationList.

9fd6244

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

minor fix.

ccec593

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

mollfpr reviewed May 27, 2024

View reviewed changes

Krishna2323 added 3 commits May 29, 2024 22:55

Merge branch 'Expensify:main' into krishna2323/issue/41249

7973dfb

update prop name.

240f49c

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

minor fix.

7fe5605

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

mollfpr reviewed May 31, 2024

View reviewed changes

Krishna2323 added 2 commits June 3, 2024 07:52

Merge branch 'Expensify:main' into krishna2323/issue/41249

c5ac464

remove commented code.

99976e0

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Fix merge conflicts.

fabcea9

mollfpr approved these changes Jun 6, 2024

View reviewed changes

melvin-bot bot requested a review from AndrewGable June 6, 2024 08:56

AndrewGable approved these changes Jun 6, 2024

View reviewed changes

AndrewGable merged commit ca986a7 into Expensify:main Jun 6, 2024

github-actions bot mentioned this pull request Jun 10, 2024

Deploy Checklist: New Expensify 2024-06-10 #43344

Closed

melvin-bot bot mentioned this pull request Jun 11, 2024

[Awaiting checklist] [$250] Can't view receipt from Split Expense details view #41249

Closed

6 tasks

Conversation

Krishna2323 commented May 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 20, 2024

Uh oh!

mollfpr commented May 21, 2024

Uh oh!

Krishna2323 commented May 22, 2024

Uh oh!

Krishna2323 commented May 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Krishna2323 commented May 23, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mollfpr commented Jun 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mollfpr commented Jun 5, 2024

Uh oh!

Krishna2323 commented Jun 6, 2024

Uh oh!

OSBotify commented Jun 6, 2024

Uh oh!

OSBotify commented Jun 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Krishna2323 commented May 20, 2024 •

edited

Loading

Krishna2323 commented May 23, 2024 •

edited

Loading

mollfpr commented Jun 5, 2024 •

edited

Loading