Fix user can submit 10-digit amount and gives an unexpected error by bernhardoj · Pull Request #42426 · Expensify/App

bernhardoj · 2024-05-21T15:00:45Z

Details

When we select a currency without decimals, we can input up to 10 digit of amount which leads to a BE error. This PR fix it.

Fixed Issues

$ #42084
PROPOSAL: #42084 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open a submit expense page
Change the currency to IQD
Verify you can't enter an amount with more than 8 digit
Select any participant and submit the expense
Verify the request is successful and won't give an error

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-21.at.22.51.32.1.mov

Android: mWeb Chrome

Screen.Recording.2024-05-21.at.22.49.34.mov

iOS: Native

Screen.Recording.2024-05-21.at.22.52.23.1.mov

iOS: mWeb Safari

Screen.Recording.2024-05-21.at.22.55.05.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-21.at.22.40.12.mov

MacOS: Desktop

Screen.Recording.2024-05-21.at.22.41.23.mov

melvin-bot · 2024-05-21T15:00:50Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ikevin127 · 2024-05-21T18:53:14Z

src/libs/MoneyRequestUtils.ts

 /**
 * Calculate the length of the amount with leading zeroes
 */
-function calculateAmountLength(amount: string, decimals: number): number {


@bernhardoj Got a type error here since you removed decimals but still passing 2 arguments down in the validateAmount function return.

ikevin127 · 2024-05-22T19:59:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-mweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

ikevin127

LGTM and tests well 👍

OSBotify · 2024-05-27T23:12:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-29T09:44:30Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.4.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

…nt-to-8-digit" This reverts commit 3599850, reversing changes made to cabf71d.

[CP Staging] Revert "Merge pull request #42426 from bernhardoj/fix/42084-limi-amount-to-8-digit"

[CP Staging] Revert "Merge pull request #42426 from bernhardoj/fix/42084-limi-amount-to-8-digit" (cherry picked from commit 06146fb)

OSBotify · 2024-05-30T21:27:19Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T21:55:14Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T22:31:44Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T22:39:17Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-06-04T13:57:46Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.78-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

always convert amount to cents

1f157e0

bernhardoj requested a review from a team as a code owner May 21, 2024 15:00

melvin-bot bot removed the request for review from a team May 21, 2024 15:00

melvin-bot bot requested a review from ikevin127 May 21, 2024 15:00

ikevin127 reviewed May 21, 2024

View reviewed changes

remove extra args

732c2e2

ikevin127 approved these changes May 22, 2024

View reviewed changes

melvin-bot bot requested a review from marcochavezf May 22, 2024 20:00

marcochavezf approved these changes May 27, 2024

View reviewed changes

marcochavezf merged commit 3599850 into Expensify:main May 27, 2024

badeggg mentioned this pull request May 28, 2024

[HOLD for payment 2024-06-06] [$250] preDeploy.yml should not skip on default branch if another run is queued #41936

Closed

github-actions bot mentioned this pull request May 29, 2024

Deploy Checklist: New Expensify 2024-05-29 #42741

Closed

francoisl added a commit that referenced this pull request May 29, 2024

Revert "Merge pull request #42426 from bernhardoj/fix/42084-limi-amou…

f8f4a92

…nt-to-8-digit" This reverts commit 3599850, reversing changes made to cabf71d.

yuwenmemon added a commit that referenced this pull request May 29, 2024

Merge pull request #42783 from Expensify/francois-blocker-42780

06146fb

[CP Staging] Revert "Merge pull request #42426 from bernhardoj/fix/42084-limi-amount-to-8-digit"

OSBotify pushed a commit that referenced this pull request May 29, 2024

Merge pull request #42783 from Expensify/francois-blocker-42780

1443949

[CP Staging] Revert "Merge pull request #42426 from bernhardoj/fix/42084-limi-amount-to-8-digit" (cherry picked from commit 06146fb)

github-actions bot mentioned this pull request May 30, 2024

Deploy Checklist: New Expensify 2024-05-30 #42872

Closed

95 tasks

melvin-bot bot mentioned this pull request May 30, 2024

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] mWeb - IOU - Creating a split expense with IQD currency & 10 digit amount unexpected error shown #42084

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix user can submit 10-digit amount and gives an unexpected error#42426

Fix user can submit 10-digit amount and gives an unexpected error#42426
marcochavezf merged 2 commits intoExpensify:mainfrom
bernhardoj:fix/42084-limi-amount-to-8-digit

bernhardoj commented May 21, 2024 •

edited

Loading

Uh oh!

melvin-bot bot commented May 21, 2024

Uh oh!

ikevin127 May 21, 2024

Uh oh!

bernhardoj May 22, 2024

Uh oh!

ikevin127 commented May 22, 2024

Uh oh!

ikevin127 left a comment

Uh oh!

OSBotify commented May 27, 2024

Uh oh!

OSBotify commented May 29, 2024

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

OSBotify commented Jun 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

bernhardoj commented May 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 21, 2024

Uh oh!

ikevin127 May 21, 2024

Choose a reason for hiding this comment

Uh oh!

bernhardoj May 22, 2024

Choose a reason for hiding this comment

Uh oh!

ikevin127 commented May 22, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

ikevin127 left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 27, 2024

Uh oh!

OSBotify commented May 29, 2024

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

OSBotify commented Jun 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bernhardoj commented May 21, 2024 •

edited

Loading