Add more Firebase performance tracing. Improve Android boot time.#4247
Merged
luacmartins merged 16 commits intomainfrom Jul 28, 2021
Merged
Add more Firebase performance tracing. Improve Android boot time.#4247luacmartins merged 16 commits intomainfrom
luacmartins merged 16 commits intomainfrom
Conversation
luacmartins
approved these changes
Jul 28, 2021
Contributor
luacmartins
left a comment
There was a problem hiding this comment.
Wow this is HUGE! Great work @marcaaron!
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
71 tasks
Contributor
|
🚀 Deployed to staging in version: 1.0.80-3🚀
|
Contributor
|
🚀 Deployed to production in version: 1.0.81-4🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR achieves a few things all related to improving or monitoring cold boot times (which need improvement on Android specifically):
sidebar_loadedso that we can check when the sidebar loads (this should be when it is actually on the screen and not when the list component lays out)Fixed Issues
$ #4027
Tests
As far as benchmarks go I timed how long it takes the sidebar to appear on screen before and after the changes
sidebar_loadBefore Changes (ms)sidebar_loadAfter Changes (ms)QA Steps
No QA
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android