Create Tag utils file by dangrous · Pull Request #42559 · Expensify/App

dangrous · 2024-05-23T20:35:54Z

Details

Next stage of #38477 - will then make new PRs for Members, and Distance Rates still to come (Categories is here).

In terms of testing, we could maybe do some spot checks re: categories, but otherwise this is just administrative and shouldn't cause any issues. No new or changed functionality, just organization.

Fixed Issues

#38477
PROPOSAL:

Tests

Just play around a bit with tags (adding, deleting, renaming, requiring, etc.) and make sure it still works. This shouldn't have any effect on user experience).

Verify that no errors appear in the JS console

Offline tests

QA Steps

No QA

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

dangrous · 2024-05-23T20:47:30Z

lol lint and jest have differing views on how to import this. it'll be fine once #42305 is merged and this is updated accordingly.

melvin-bot · 2024-05-28T21:46:15Z

@lakchote Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

lakchote

One NAB comment, and there are conflicts. Other than that LGTM 👍

lakchote · 2024-05-29T07:07:49Z

src/libs/actions/Policy/Tag.ts

+        if (!key) {
+            return;
+        }
+        if (val === null || val === undefined) {


Suggested change

if (val === null || val === undefined) {

if (!val) {

I think this might be because val could be an empty string, which would still be false? Not sure, this is just copied wholesale from Policy.ts. I might leave it for now unless you disagree.

dangrous · 2024-05-29T16:02:35Z

conflicts resolved!

luacmartins · 2024-05-29T17:25:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

N/A just moving code around

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2024-05-30T21:55:41Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T22:32:11Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-06-04T13:58:13Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.78-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

allgandalf · 2024-07-02T06:10:02Z

src/libs/actions/Policy/Tag.ts

+                                pendingFields: {
+                                    name: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
+                                },


We missed to spread the tag list here which caused #42917.

IMO, this was a big PR so it's just a missed case from the implementation

Hi @allgandalf! So I actually didn't modify any code in this PR - I just moved it - so the missing spread looks like it came from the old file:

https://github.com/Expensify/App/pull/42559/files/9cf6a9fa77812f0ddec251d22ef2d5ab71201c04#diff-c3278b76b0699dc5c04d47722c67669ef432ee715141b506716a6be212eb3f08L3437-L3439

Not trying to pass the blame but more to help us find the original author!

Umm, sorry for the Overlook, by the PR name create tag utils file i assumed this was a new feature implementation :)

ZhenjaHorbach · 2024-07-17T08:10:34Z

src/libs/actions/Policy/Tag.ts

+                    errors: {
+                        [oldName]: oldName,
+                        [newName]: ErrorUtils.getMicroSecondOnyxError('workspace.tags.genericFailureMessage'),
+                    },


This change caused this issue.
We don't need to pass errors separately from tag objects

hi! So this PR was just moving all the code from Policy.ts to Policy/Tag.ts - no changes in the code (that issue already existed prior to this). It'll be annoying to go through the history (sorry!) but we should try to find the real PR that caused the issue instead of this one.

Oh, yeah
My fault, sorry 😅
I'll try to check history a little deeper

all good! You're not the first (and it's confusing)

dangrous added 8 commits May 23, 2024 16:02

create base tag file

982f3b6

remove non-tag methods

614c88f

start swapping references

eb78ffc

more reference swaps

fc8653d

swap final references

2bbee5a

remove methods from Policy.ts

16440a1

prettier

3186cb9

fix import from Policy to Tag

74bd7da

dangrous self-assigned this May 23, 2024

dangrous added 3 commits May 28, 2024 17:17

merge conflicts

db613d7

update based on new changes

8d1d3dc

remove functions from Policy.ts

9a05ffc

dangrous mentioned this pull request May 28, 2024

Create Category utils file #42305

Merged

50 tasks

dangrous marked this pull request as ready for review May 28, 2024 21:45

dangrous requested a review from a team as a code owner May 28, 2024 21:45

melvin-bot bot requested review from lakchote and removed request for a team May 28, 2024 21:46

lakchote reviewed May 29, 2024

View reviewed changes

dangrous added 2 commits May 29, 2024 11:51

merge conflicts

728dabd

add back newline

9cf6a9f

luacmartins approved these changes May 29, 2024

View reviewed changes

amyevans approved these changes May 29, 2024

View reviewed changes

luacmartins merged commit 52d4945 into main May 29, 2024

luacmartins deleted the dangrous-tagutilsfile branch May 29, 2024 22:10

github-actions bot mentioned this pull request May 30, 2024

Deploy Checklist: New Expensify 2024-05-30 #42872

Closed

95 tasks

hayata-suenaga mentioned this pull request May 31, 2024

feat: add switch toggle #42952

Closed

50 tasks

allgandalf reviewed Jul 2, 2024

View reviewed changes

allgandalf mentioned this pull request Jul 2, 2024

[HOLD for payment 2024-06-28] [$250] Tags - Enable tag option is no longer grayed out after renaming tag offline #42917

Closed

6 tasks

ZhenjaHorbach reviewed Jul 17, 2024

View reviewed changes

ZhenjaHorbach mentioned this pull request Jul 17, 2024

[HOLD for payment 2024-07-22] [$250] Tag - App crashes when saving 0 as custom tag name #43773

Closed

6 tasks

Conversation

dangrous commented May 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

dangrous commented May 23, 2024

Uh oh!

melvin-bot bot commented May 28, 2024

Uh oh!

lakchote left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dangrous commented May 29, 2024

Uh oh!

luacmartins commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

OSBotify commented Jun 4, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dangrous Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dangrous commented May 23, 2024 •

edited

Loading

luacmartins commented May 29, 2024 •

edited

Loading

dangrous Jul 17, 2024 •

edited

Loading