Skip to content

Add beta check to Workspaces page#4259

Merged
johnmlee101 merged 3 commits intomainfrom
amal-new-workspace-url-beta
Jul 28, 2021
Merged

Add beta check to Workspaces page#4259
johnmlee101 merged 3 commits intomainfrom
amal-new-workspace-url-beta

Conversation

@TomatoToaster
Copy link
Contributor

@TomatoToaster TomatoToaster commented Jul 27, 2021

@johnmlee101, please review when you get the chance.

Details

Add Beta Check to workspaces page. These changes don't to be CP'ed because these pages aren't functional if you aren't in the beta and also if you haven't already created a workspace. However you can still access new.expensify.com/workspace and if you somehow knew the URL you shouldn't see that page. It'll look unfunctional since there's no sidebar:
image

This is valuable for us because switching between accounts that are in beta and outside of beta (if you were on the workspace settings page last) won't redirect you to the regular chat page, but show you this weird unfunctional modal instead modal instead.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/172009

Tests

Locally all betas should be active, so these steps were used to verify this works

  1. Change this line to get rid of the || canUseAllBetas(betas) so that your local dev account doesn't have access to the beta.
  2. Go to localhost:8080/workspace and localhost:8080/workspace/undefined/people and localhost:8080/workspace/undefined/card
  3. Verify all 3 of those links bring you back to a regular chat page and does not open a blank modal like in the screenshots below.

QA Steps

Don't need to test the people page portion of this because you can't really be in a workspace

  1. Log in with an account that is NOT in the freePlan beta
  2. Go to staging.new.expensify.com/workspace and make sure you can't see a modal like this (you should get redirected to chat like you just logged in):
    image
  3. Go to staging.new.expensify.com/workspace/undefined/card and verify you do not see a modal like above
  4. Go to staging.new.expensify.com/workspace/undefined/people and verify you do NOT see a modal like this:
    image

Tested On

Only affects web.

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Included in QA steps.

@TomatoToaster TomatoToaster self-assigned this Jul 27, 2021
@TomatoToaster TomatoToaster marked this pull request as ready for review July 27, 2021 23:55
@TomatoToaster TomatoToaster requested a review from a team as a code owner July 27, 2021 23:55
@MelvinBot MelvinBot requested review from johnmlee101 and removed request for a team July 27, 2021 23:55
Copy link
Contributor

@johnmlee101 johnmlee101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good!

@johnmlee101 johnmlee101 merged commit b964c89 into main Jul 28, 2021
@johnmlee101 johnmlee101 deleted the amal-new-workspace-url-beta branch July 28, 2021 15:03
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.80-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.81-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants