Merged
Conversation
johnmlee101
approved these changes
Jul 28, 2021
Contributor
johnmlee101
left a comment
There was a problem hiding this comment.
I think this looks good!
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
71 tasks
Contributor
|
🚀 Deployed to staging in version: 1.0.80-3🚀
|
Contributor
|
🚀 Deployed to production in version: 1.0.81-4🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@johnmlee101, please review when you get the chance.
Details
Add Beta Check to workspaces page. These changes don't to be CP'ed because these pages aren't functional if you aren't in the beta and also if you haven't already created a workspace. However you can still access

new.expensify.com/workspaceand if you somehow knew the URL you shouldn't see that page. It'll look unfunctional since there's no sidebar:This is valuable for us because switching between accounts that are in beta and outside of beta (if you were on the workspace settings page last) won't redirect you to the regular chat page, but show you this weird unfunctional modal instead modal instead.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/172009
Tests
Locally all betas should be active, so these steps were used to verify this works
|| canUseAllBetas(betas)so that your local dev account doesn't have access to the beta.localhost:8080/workspaceandlocalhost:8080/workspace/undefined/peopleandlocalhost:8080/workspace/undefined/cardQA Steps
Don't need to test the people page portion of this because you can't really be in a workspace
staging.new.expensify.com/workspace/undefined/cardand verify you do not see a modal like abovestaging.new.expensify.com/workspace/undefined/peopleand verify you do NOT see a modal like this:Tested On
Only affects web.
Screenshots
Included in QA steps.