IOU - Autofocus 'What's it for?' text box in details page#4263
IOU - Autofocus 'What's it for?' text box in details page#4263roryabraham merged 1 commit intoExpensify:mainfrom rushatgabhane:autofocus
Conversation
roryabraham
left a comment
There was a problem hiding this comment.
LGTM, I didn't see any react-navigation bugs either 👍
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Just want to confirm - does the keyboard launch on all devices when this field is autofocused? I think it should, but the screenshots make it seem like it might not be the case. |
Yes they do, but I had hardware keyboard on in the simulator. |
|
Sounds good, thanks for confirming! |
|
Yes, I confirmed that too. @rushatgabhane Just in case you weren't aware, to make the software keyboard work in an iOS simulator you can go to |
Too bad we can't raise an issue on their repo 😆 |
|
🚀 Deployed to staging in version: 1.0.80-3🚀
|
|
🚀 Deployed to production in version: 1.0.81-4🚀
|
Details
Added
autoFocusprop toTextInputI didn't encounter any bugs that were mentioned in this comment.
Fixed Issues
$ #4215
Tests / QA
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android