Use proper width for Cancel/Decline Button Text

[aman-atg]

Details

(Comment)

Fixed Issues

$ #4234

Tests || ### QA Steps

1. Login to New Expensify
2. Change language to Spanish
3. Request money from someone or Go to a chat where money is requested from you
4. Click on the amount or view details link
5. button text will not look unusual (Cancel/Decline)

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[tgolen]

Looks great, and just like the proposal!

Can you please complete the rest of the platform testing before I merge this?

[aman-atg]

Can you please complete the rest of the platform testing before I merge this?

@tgolen , the issue isn't happening on Android. And Sorry, I'm yet to get a macbook for other two platforms.

[tgolen]

OK, you still need to get an Android screenshot to show there are no regressions. I can test it out on iOS and the desktop app for you (I won't get to it until tomorrow).

[tgolen]

All right, I tested it on desktop, and ran into an issue. It looks like this corrupted the width of the dropdowns somehow. Here is the preferences screen on main and on this branch. Not only is the width different, but the text is now centered when it wasn't before (maybe this is fixed on main and you just need to merge that into your branch?).

main

this branch

[aman-atg]

(maybe this is fixed on main and you just need to merge that into your branch?).

That must be the case as the removed style is not being used anywhere else.

[aman-atg]

Added a screenshot from android.

[tgolen]

Well, I was able to do it today after all! iOS looks good. I verified that when I merge main into this branch, it fixes that layout on the preferences page. Gonna go ahead and merge.

[tgolen]

once the tests are done

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging in version: 1.0.81-5🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production in version: 1.0.82-7🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅