Implement unvalidated signups for newDot by techievivek · Pull Request #42887 · Expensify/App

techievivek · 2024-05-31T02:26:27Z

Hold until https://github.com/Expensify/Web-Expensify/pull/42216 is deployed to PROD.

Details

This adds the unvalidated signup on newDot. For a new user who is not on a controlled domain when they signup we directly take them to the product. No need of any magic code for the signup process.

Fixed Issues

Part of #30794
PROPOSAL: N/A

Tests

New signup flow testing

You have to be on this web-E PR to test this.
Open NewDot and logout if you are already in a session.
Provide a new email from a new domain and click "Continue" to create a new account.
Confirm that you're taken to a welcome screen page that reads <email>, it's always great to see a new face around here! Please continue by tapping the join button below.
Confirm you are taken back to email input screen when you click on back button.
Confirm that you're signed in after clicking "Join."
Confirm that there is a green dot next to the avatar indicating that the account is invalidated.

Existing account signup flow

Sign out from NewDot if you are already in a session.
Try to sign into the account you created in step 2
Confirm that you're required to provide a validation code this time.
Confirm an email with the validation is sent to you.
Provide the validation code and confirm that you're signed in.
Confirm there is no green dot next to your avatar.

Domain control account testing

Create an account on newDot on a domain where the domain account is already created.
Confirm you are asked to enter the magic code, and you are not directly taken to the product.

Login with a 2fa account [Only on Staging or PROD]

Try logging in to Newdot with an account that is already created and has the 2FA setup.
Confirm it asks for magic code and then the 2FA code.
Once you enter those info, you are signed in.

Verify that no errors appear in the JS console

Offline tests

Go offline mode and confirm the continue button is disabled and it says you are offline.
No other specific testing since this feature requires user to be online.

QA Steps

Same as above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-06-03.at.11.54.49.AM.mov

MacOS: Desktop

desktop-test.mov

melvin-bot · 2024-06-03T06:52:09Z

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hayata-suenaga · 2024-06-03T14:41:00Z

The flow tested well for me

will do more close code review later today 👍

rushatgabhane · 2024-06-04T15:36:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

my sim isn't working for mweb chrome

iOS: Native

Screen.Recording.2024-06-04.at.18.49.02.mov

iOS: mWeb Safari

Screen.Recording.2024-06-04.at.18.46.42.mov

MacOS: Chrome / Safari

Green dot

Existing account

MacOS: Desktop

Screen.Recording.2024-06-04.at.18.52.40.mov

melvin-bot · 2024-06-04T15:56:49Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-06-04T15:56:52Z

🎯 @rushatgabhane, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #43039.

trjExpensify · 2024-06-04T20:20:03Z

@techievivek for the copy here, where did that come from?

I don't think we need the second sentence, and we can just match exactly what is on OldDot for consistency. OldDot ref below:

CC: @jamesdeanexpensify for a second opinion on that. Also, @shawnborton @dannymcclain @dubielzyk-expensify is the Join button size all good?

jamesdeanexpensify · 2024-06-04T20:22:07Z

sounds good to me re:copy @trjExpensify !

dannymcclain · 2024-06-04T20:26:31Z

I think I would prefer if it more closely matched the Continue button (with the Back link below the button instead of next to it). But I mean it's not the end of the world with how it is now. Curious for Shawn and Jon's thoughts.

NikkiWines

Looking good so far! Only thing is I think the copy with Welcome! <login>, is a bit awkward. Maybe we should remove the !?

NikkiWines · 2024-06-05T06:17:36Z

src/pages/signin/SignInPage.tsx

+    const userLogin = Str.removeSMSDomain(credentials?.login ?? '');
+
+    // replacing spaces with "hard spaces" to prevent breaking the number
+    const userLoginToDisplay = Str.isSMSLogin(userLogin) ? formatPhoneNumber(userLogin).replace(/ /g, '\u00A0') : userLogin;


NAB since you didn't add this logic to begin with, but can we move the .replace(/ /g, '\u00A0') inside of formatPhoneNumber?

techievivek · 2024-06-05T09:31:28Z

Looking good so far! Only thing is I think the copy with Welcome! , is a bit awkward. Maybe we should remove the !?

Yeah, that happens on the small screen. For large Welcome! moves in its own header. We use the same constant at both places. Maybe we can bring a new welcomeWithoutExclamation so we can use here?

trjExpensify · 2024-06-05T09:49:53Z

Looking good so far! Only thing is I think the copy with Welcome! , is a bit awkward. Maybe we should remove the !?

Yeah, that happens on the small screen. For large Welcome! moves in its own header. We use the same constant at both places. Maybe we can bring a new welcomeWithoutExclamation so we can use here?

If it's a simple change, let's do it. I agree it looks better, I wouldn't block on it though really.

techievivek · 2024-06-05T09:55:40Z

@trjExpensify To confirm, we need welcome! (with exclamation) on large screens and welcome(no exclamation) on small screens? Or only welcome(no exclamation) in both?

trjExpensify · 2024-06-05T10:02:58Z

Only on small screens here where we don't have Welcome! as the header already like we do on large screens.

So on small screens that would be:

Manage spend, split expenses, and chat with your team.
Welcome tom@derp.com, it's always great to see a new face around here!

On large screens it's:

Welcome!
tom@derp.com, it's always great to see a new face around here!

techievivek · 2024-06-05T10:28:29Z

Updated screen recording of testing.

Screen.Recording.2024-06-05.at.3.46.13.PM.mov

rushatgabhane

Code LGTM

Screenshots/Videos

Android: Native

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-06-05T10:52:41Z

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2024-06-05T15:00:37Z

Screen recordings look good to me 👍

NikkiWines

Looks great, approving but not merging while we wait on the web PR

NikkiWines · 2024-06-05T22:32:27Z

src/pages/signin/SignInPage.tsx


+    const userLogin = Str.removeSMSDomain(credentials?.login ?? '');
+
+    // replacing spaces with "hard spaces" to prevent breaking the number


NAB: You don't need this comment (or surrounding whitespace) since this change is occurring within formatPhoneNumber now

hayata-suenaga

code looks good to me thank you for the work Vivek!

trjExpensify · 2024-06-06T20:57:26Z

WebPR is on prod, let's take this off hold and merge it so it gets to staging with the app deploy later. :)

techievivek · 2024-06-06T21:00:06Z

Merging now since the web-e changes are on prod and this has been already approved.

OSBotify · 2024-06-06T21:08:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

NikkiWines · 2024-06-11T18:51:02Z

@techievivek this PR appears to have caused this deploy blocker because users are getting booted out after validating their logins in app

OSBotify · 2024-06-11T23:33:13Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

techievivek added 6 commits May 31, 2024 05:37

added translation

925a5a1

updatd API call

90ea20e

signs up an user

efb056f

add new user signup page

6bff5d3

added signup welcome form to login flow

4482d55

lint fixes

acf1a13

techievivek self-assigned this May 31, 2024

techievivek added 4 commits May 31, 2024 07:57

add EOL

b2aac33

fix type

300f23e

minor fixes

b10a47d

style fixes

9217680

techievivek requested review from NikkiWines, hayata-suenaga and johnmlee101 June 3, 2024 06:51

techievivek marked this pull request as ready for review June 3, 2024 06:52

techievivek requested a review from a team as a code owner June 3, 2024 06:52

melvin-bot bot removed the request for review from a team June 3, 2024 06:52

techievivek changed the title ~~Implement unvalidated signups for newDot~~ [HOLD Web-E 42216] Implement unvalidated signups for newDot Jun 3, 2024

techievivek requested a review from rushatgabhane June 4, 2024 13:30

rushatgabhane approved these changes Jun 4, 2024

View reviewed changes

melvin-bot bot requested a review from srikarparsi June 4, 2024 15:56

melvin-bot bot mentioned this pull request Jun 4, 2024

Payment issue for E/App PR#42887 #43039

Closed

NikkiWines reviewed Jun 5, 2024

View reviewed changes

some UI fixes

78cbc57

fix lint and added a new welcome variant

f093d51

techievivek requested a review from rushatgabhane June 5, 2024 10:17

style fixes

f5b6e63

techievivek requested a review from NikkiWines June 5, 2024 10:29

rushatgabhane approved these changes Jun 5, 2024

View reviewed changes

melvin-bot bot requested a review from carlosmiceli June 5, 2024 10:52

techievivek removed request for carlosmiceli and srikarparsi June 5, 2024 10:53

NikkiWines approved these changes Jun 5, 2024

View reviewed changes

hayata-suenaga approved these changes Jun 5, 2024

View reviewed changes

trjExpensify changed the title ~~[HOLD Web-E 42216] Implement unvalidated signups for newDot~~ Implement unvalidated signups for newDot Jun 6, 2024

techievivek merged commit 60ca2ff into main Jun 6, 2024

techievivek deleted the techievivek_implement_unvalidated_signup branch June 6, 2024 21:00

github-actions bot mentioned this pull request Jun 10, 2024

Deploy Checklist: New Expensify 2024-06-10 #43344

Closed

sakluger mentioned this pull request Jun 14, 2024

[Unvalidated Sign-Up] Allow new account sign ins to not require account validation in NewDot #30794

Closed

danielrvidal mentioned this pull request Jul 2, 2024

[Guided Setup Stage 3] Workspace invites not including a link for invalidated sign ins for first time users #44749

Closed


		const userLogin = Str.removeSMSDomain(credentials?.login ?? '');

		// replacing spaces with "hard spaces" to prevent breaking the number

Conversation

techievivek commented May 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

New signup flow testing

Existing account signup flow

Domain control account testing

Login with a 2fa account [Only on Staging or PROD]

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 3, 2024

Uh oh!

hayata-suenaga commented Jun 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rushatgabhane commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Green dot

Existing account

Uh oh!

melvin-bot bot commented Jun 4, 2024

Uh oh!

melvin-bot bot commented Jun 4, 2024

Uh oh!

trjExpensify commented Jun 4, 2024

Uh oh!

jamesdeanexpensify commented Jun 4, 2024

Uh oh!

dannymcclain commented Jun 4, 2024

Uh oh!

NikkiWines left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NikkiWines Jun 5, 2024

Choose a reason for hiding this comment

Uh oh!

techievivek commented Jun 5, 2024

Uh oh!

trjExpensify commented Jun 5, 2024

Uh oh!

techievivek commented Jun 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trjExpensify commented Jun 5, 2024

Uh oh!

techievivek commented Jun 5, 2024

Uh oh!

rushatgabhane left a comment

Choose a reason for hiding this comment

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 5, 2024

Uh oh!

shawnborton commented Jun 5, 2024

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

NikkiWines Jun 5, 2024

Choose a reason for hiding this comment

Uh oh!

hayata-suenaga left a comment

Choose a reason for hiding this comment

Uh oh!

trjExpensify commented Jun 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

techievivek commented Jun 6, 2024

Uh oh!

OSBotify commented Jun 6, 2024

Uh oh!

NikkiWines commented Jun 11, 2024

techievivek commented May 31, 2024 •

edited

Loading

hayata-suenaga commented Jun 3, 2024 •

edited

Loading

rushatgabhane commented Jun 4, 2024 •

edited

Loading

NikkiWines left a comment •

edited

Loading

techievivek commented Jun 5, 2024 •

edited

Loading

trjExpensify commented Jun 6, 2024 •

edited

Loading