[CP Staging] Revert "Bump expensify-common version"#42914
Conversation
|
Noting that another crash is probably caused by suspect PR. So we need to test it |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
|
From my tests on Android:
|
Yeah, that's weird. Did you removed the mention or it got automatically removed?
Nice! No, I think we're trying to fix the bug when copying the announce mention crashes the app. It didn't crash, so looks good |
It looks like it got automatically removed 🤔 i think that's actually already on prod, i've seen other "copy into the composer not working" issues on prod |
|
Same behavior on iOS, the mention is removed when edited Screen.Recording.2024-05-31.at.7.34.23.PM.mov |
|
@MonilBhavsar and I tested this in android & ios which is where the bugs occurred, so let's merge 🚀 |
…n-bump [CP Staging] Revert "Bump expensify-common version" (cherry picked from commit 968520a)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Working well on iOS & android! |
|
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 1.4.78-3 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.78-5 🚀
|
Reverts #42176
Because PR ^ causes #42888
cc @MonilBhavsar
Tests
Make sure these issues don't happen anymore:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.