Revert "fix: Taxes - App allows deleted tax rate to be selected as currency default in offline mode."#42953
Revert "fix: Taxes - App allows deleted tax rate to be selected as currency default in offline mode."#42953
Conversation
…rrency default in offline mode."
|
@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@iwiznia, do we need a revert? I was waiting for response on #42620 (comment). |
|
We don't need it but seems like the simplest option. You can work on re-sending the PR with the needed changes without us having to decide between blocking a deploy or deploying "broken" code or having to do a CP to staging. |
|
Oh wait, I guess we will have to CP the code either way (or deploy the broken code). Anyway, we can close this revert if the PR you send is ready to go in the next deploy. |
|
@iwiznia, ok, can you pls confirm this #42620 (comment) for me? After that I will raise the PR within an hour or two. |
I think you'll find the answer to it in the issue that was open here #42918 |
|
Followup PR #42974 is made, so I think we can close this. Thanks @Krishna2323! |
|
Can we close this? |
|
I think we can close 😀 |
Reverts #42620
Caused #42918 (comment)
cc @Krishna2323