Fix applying onyx updates from push notifications by arosiclair · Pull Request #43056 · Expensify/App

arosiclair · 2024-06-04T19:01:08Z

Details

Adds a separate flow for applying onyx updates from push notifications. This fixes an issue where we try to apply them using event handlers for Pusher with an invalid eventType which results in a no-op.

Fixed Issues

$ #43047

Tests

Android

Log in
Accept push notification prompt
Kill the app
Send yourself a message
Verify a push notification appears
View logs and verify an update is applied in the background (may take a minute)

 [PushNotification] Callback triggered for com.airship.push_received - ""
 [PushNotification] Applying onyx data in the background - {"reportID":624968496832156,"reportActionID":"4653738563044339674"}
 [PushNotification] reliable onyx update received - {"lastUpdateID":7288,"previousUpdateID":7287,"onyxDataCount":2}
 [OnyxUpdateManager] Applying update type: airship with lastUpdateID: 7288 - {}
 [Onyx] merge called for key: OnyxUpdatesLastUpdateIDAppliedToClient hasChanged: true - ""
 [OnyxUpdateManager] Applying Airship updates
 [Onyx] merge called for key: report_624968496832156 properties: lastActorAccountID,lastMessageText,lastVisibleActionCreated,reportID hasChanged: true - ""
 [Onyx] merge called for key: reportActions_624968496832156 properties: 4653738563044339674 hasChanged: true - ""
 [OnyxUpdateManager] Done applying Airship updates

Enable airplane mode
Click the push notification
Verify the app opens, you're navigated to the chat and the message displays

iOS

Log in
Accept push notification prompt
Kill the app
Send yourself a message
Verify a push notification appears
Click the push notification
Verify the app opens, you're navigated to the chat and the message displays
View logs and verify an update is applied

 [PushNotification] Callback triggered for com.airship.push_received - ""
 [PushNotification] Applying onyx data in the background - {"reportID":624968496832156,"reportActionID":"4653738563044339674"}
 [PushNotification] reliable onyx update received - {"lastUpdateID":7288,"previousUpdateID":7287,"onyxDataCount":2}
 [OnyxUpdateManager] Applying update type: airship with lastUpdateID: 7288 - {}
 [Onyx] merge called for key: OnyxUpdatesLastUpdateIDAppliedToClient hasChanged: true - ""
 [OnyxUpdateManager] Applying Airship updates
 [Onyx] merge called for key: report_624968496832156 properties: lastActorAccountID,lastMessageText,lastVisibleActionCreated,reportID hasChanged: true - ""
 [Onyx] merge called for key: reportActions_624968496832156 properties: 4653738563044339674 hasChanged: true - ""
 [OnyxUpdateManager] Done applying Airship updates

Offline tests

None

QA Steps

None

PR Author Checklist

Screenshots/Videos

Android: Native

screen-20240605-113232.2.mp4

iOS: Native

RPReplay_Final1717603620.MP4

melvin-bot · 2024-06-05T16:11:07Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

alitoshmatov · 2024-06-13T05:26:39Z

I tried it to test it on simulator and I couldn't achieve it. I will ask for other C+ to take it over

c3024 · 2024-06-13T12:02:29Z

I would like to take this over.

Since this involves push notifications, it cannot be tested on a local dev build on a physical iOS device as far as I know.

So, can you please run an adhoc build here, @arosiclair ?

arosiclair · 2024-06-17T14:09:41Z

@alitoshmatov @c3024 iOS push notifications can only be tested internally and mobile push notifications do not work in Ad-hoc builds.

c3024 · 2024-06-17T17:59:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

pushAndroid.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

c3024 · 2024-06-17T18:06:23Z

Tests well on Android emulator but all images on the app disappeared after opening the app through notification. This issue does not appear to be related to this PR. I am checking now on a physical device.

c3024 · 2024-06-17T19:00:39Z

Tests well on Android emulator but all images on the app disappeared after opening the app through notification. This issue does not appear to be related to this PR. I am checking now on a physical device.

This behaviour is also there on main.

c3024

Looks good and tests well.

melvin-bot · 2024-06-17T19:02:14Z

@aldo-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2024-06-17T20:00:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-17T23:47:41Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.4.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-06-18T00:05:07Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.4.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-06-18T16:01:52Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.4.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-06-21T16:48:42Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.85-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

arosiclair added 3 commits June 4, 2024 14:54

add seperate handler for applying onyx updates from airship

bf38db1

log warning for unhandled pusher events

f20e04d

clear useless eventType

340038d

arosiclair self-assigned this Jun 4, 2024

add OnyxUpdates test for applying airship updates

45243f8

arosiclair marked this pull request as ready for review June 5, 2024 16:11

arosiclair requested a review from a team as a code owner June 5, 2024 16:11

melvin-bot bot removed the request for review from a team June 5, 2024 16:11

melvin-bot bot requested a review from alitoshmatov June 5, 2024 16:11

arosiclair requested review from c3024 and removed request for alitoshmatov June 17, 2024 14:25

c3024 approved these changes Jun 17, 2024

View reviewed changes

melvin-bot bot requested a review from aldo-expensify June 17, 2024 19:02

aldo-expensify approved these changes Jun 17, 2024

View reviewed changes

aldo-expensify merged commit eb59c33 into main Jun 17, 2024

aldo-expensify deleted the arosiclair-push-notif-onyx-updates branch June 17, 2024 19:51

github-actions bot mentioned this pull request Jun 17, 2024

Deploy Checklist: New Expensify 2024-06-17 #43871

Closed

44 tasks

melvin-bot bot mentioned this pull request Jun 21, 2024

[HOLD for payment 2024-06-28] Push notification Onyx updates are not applied when there is no gap detected #43047

Closed

6 tasks

Conversation

arosiclair commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 5, 2024

Uh oh!

alitoshmatov commented Jun 13, 2024

Uh oh!

c3024 commented Jun 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arosiclair commented Jun 17, 2024

Uh oh!

c3024 commented Jun 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

c3024 commented Jun 17, 2024

Uh oh!

c3024 commented Jun 17, 2024

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Jun 17, 2024

Uh oh!

OSBotify commented Jun 17, 2024

Uh oh!

OSBotify commented Jun 17, 2024

Uh oh!

OSBotify commented Jun 18, 2024

Uh oh!

OSBotify commented Jun 18, 2024

Uh oh!

OSBotify commented Jun 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

arosiclair commented Jun 4, 2024 •

edited

Loading

c3024 commented Jun 13, 2024 •

edited

Loading

c3024 commented Jun 17, 2024 •

edited

Loading