Skip to content

[No QA] Fix Flipper for Android #4317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jag96 merged 4 commits into from
Jul 30, 2021
Merged

[No QA] Fix Flipper for Android #4317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d21e44b
derp
marcaaron Jul 30, 2021
46f350a
meh
marcaaron Jul 30, 2021
b73292c
meh
marcaaron Jul 30, 2021
eaca493
Merge remote-tracking branch 'origin' into marcaaron-fixFlipperOnAndroid
marcaaron Jul 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/app/src/debug/java/com/reactnativechat/ReactNativeFlipper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* <p>This source code is licensed under the MIT license found in the LICENSE file in the root
* directory of this source tree.
*/
package com.expensifyreactnative.chat;
package com.reactnativechat;

import android.content.Context;
import com.facebook.flipper.android.AndroidFlipperClient;
Expand Down
3 changes: 1 addition & 2 deletions android/app/src/main/java/com/expensify/chat/MainApplication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@

import org.unimodules.adapters.react.ModuleRegistryAdapter;
import org.unimodules.adapters.react.ReactModuleRegistryProvider;
import org.unimodules.core.interfaces.SingletonModule;
import com.facebook.react.bridge.JSIModulePackage;
import com.swmansion.reanimated.ReanimatedJSIModulePackage;

Expand Down Expand Up @@ -107,7 +106,7 @@ private static void initializeFlipper(
We use reflection here to pick up the class that initializes Flipper,
since Flipper library is not available in release mode
*/
Class<?> aClass = Class.forName("com.expensify.chat.ReactNativeFlipper");
Class<?> aClass = Class.forName("com.reactnativechat.ReactNativeFlipper");
aClass
.getMethod("initializeFlipper", Context.class, ReactInstanceManager.class)
.invoke(null, context, reactInstanceManager);
Expand Down
2 changes: 1 addition & 1 deletion android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ AsyncStorage_db_size_in_MB=10
AsyncStorage_useNextStorage=true

# Version of flipper SDK to use with React Native
FLIPPER_VERSION=0.54.0
FLIPPER_VERSION=0.100.0

# Key Store Information
MYAPP_UPLOAD_STORE_FILE=my-upload-key.keystore
Expand Down
Loading