Skip to content

Add user's accountID to the api/ping command #43385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dangrous merged 3 commits into from
Jun 13, 2024
Merged

Add user's accountID to the api/ping command #43385

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
760de92
Add user's accountID to the api/ping command
tgolen Jun 10, 2024
14bd2be
Fix TS error
tgolen Jun 10, 2024
c0b3c73
Don't log a zero
tgolen Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/libs/NetworkConnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,17 @@ Onyx.connect({
},
});

let accountID = 0;
Onyx.connect({
key: ONYXKEYS.SESSION,
callback: (session) => {
if (!session?.accountID) {
return;
}
accountID = session.accountID;
},
});

/**
* Set interval to periodically (re)check backend status.
* Because backend unreachability might imply lost internet connection, we need to check internet reachability.
Expand All @@ -107,7 +118,7 @@ function subscribeToBackendAndInternetReachability(): () => void {
return;
}
// Using the API url ensures reachability is tested over internet
fetch(`${CONFIG.EXPENSIFY.DEFAULT_API_ROOT}api/Ping`, {
fetch(`${CONFIG.EXPENSIFY.DEFAULT_API_ROOT}api/Ping?accountID=${accountID || 'unknown'}`, {
method: 'GET',
cache: 'no-cache',
})
Expand Down