Update XCode to fix iOS deploy by Jag96 · Pull Request #4339 · Expensify/App

Jag96 · 2021-07-30T21:59:08Z

Details

This PR updates the XCode version to fix an issue where fastlane is failing because of a mismatch.

Fixed Issues

Tests

Building the app and archiving it works fine for me, so the next best way to test this is to merge and confirm the deploy doesn't fail

QA Steps

None

Tested On

iOS

Screenshots

N/A

Jag96 · 2021-07-30T21:59:26Z

ios/Podfile.lock

  - UMConstantsInterface (6.1.0):
    - UMCore
-  - UMCore (7.1.0)
+  - UMCore (7.1.1)


These automatically updated when running pod install

Jag96 · 2021-07-30T22:02:34Z

Looks like e2e fails now, will likely have to fix broken dependencies 👀

Jag96 · 2021-07-30T22:17:26Z

From the failing build, looks like /Applications/Xcode_12.5.app/ doesn't have anything there

Fetching aws-sdk-kms 1.43.0
Installing aws-sdk-kms 1.43.0
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

current directory:
/Users/runner/work/App/App/vendor/bundle/ruby/2.7.0/gems/json-2.5.1/ext/json/ext/generator
/Users/runner/hostedtoolcache/Ruby/2.7.4/x64/bin/ruby -I
/Users/runner/hostedtoolcache/Ruby/2.7.4/x64/lib/ruby/2.7.0 -r
./siteconf20210730-1267-rn4l0w.rb extconf.rb
creating Makefile

current directory:
/Users/runner/work/App/App/vendor/bundle/ruby/2.7.0/gems/json-2.5.1/ext/json/ext/generator
make "DESTDIR=" clean
xcrun: error: missing DEVELOPER_DIR path:
/Applications/Xcode_12.5.app/Contents/Developer

current directory:
/Users/runner/work/App/App/vendor/bundle/ruby/2.7.0/gems/json-2.5.1/ext/json/ext/generator
make "DESTDIR="
xcrun: error: missing DEVELOPER_DIR path:
/Applications/Xcode_12.5.app/Contents/Developer

make failed, exit code 1

Jag96 · 2021-07-30T22:23:42Z

Looks like GH actions available versions only go up to 12.4 for macos-latest which is 10.15:

So for 12.5 we'd have to update to macos-11 per https://github.com/actions/virtual-environments#available-environments

https://github.com/actions/virtual-environments/blob/main/images/macos/macos-11-Readme.md#xcode

Going to give that a shot and see what the result is

Jag96 · 2021-07-30T22:54:02Z

Looks like we need to match the schemas in https://json.schemastore.org/github-workflow.json, so macos-11.0 instead of macos-11. However, that seems to break the e2e (which didn't break with macos-11). I believe we'll have to update the validateActionsAndWorkflows script to fix this cc @roryabraham.

aldo-expensify · 2021-07-31T01:30:45Z

Sorry @Jag96 , I don't know how to test this, and it will take me some time to figure it out. I'll be off on Monday, so you may want to choose someone with more experience to review this :)

roryabraham · 2021-08-02T13:57:03Z

Great investigation so far @Jag96!

I believe we'll have to update the validateActionsAndWorkflows script to fix this cc @roryabraham.

Okay, I guess for now the best thing to do might be to:

Switch back to runs-on: macos-11
Just disable that check in our CI/CD for now
Submit a PR against schemastore to update the JSON schema.
Once that PR is merged, re-enable the schema verification.

roryabraham · 2021-08-02T14:14:54Z

SchemaStore PR here

roryabraham · 2021-08-02T16:20:30Z

Whoa, the SchemaStore PR is already merged, so the schema validation check is passing ✅ 🎉

Jag96 · 2021-08-02T16:50:38Z

Putting this into review, looks like e2e got past the part where it was previously failing so this should be good 🤞

roryabraham

Okay, this seems pretty simple – update the runners to macos-11 and xcode to 12.5. Hopefully this works!

OSBotify · 2021-08-02T17:15:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Update XCode to fix iOS deploy (cherry picked from commit 8db44bc)

OSBotify · 2021-08-02T19:25:31Z

🚀 Deployed to staging in version: 1.0.82-2🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2021-08-06T02:42:49Z

🚀 Deployed to production in version: 1.0.82-7🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2021-08-06T03:18:01Z

🚀 Deployed to staging in version: 1.0.82-8🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2021-08-11T22:18:27Z

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Update XCode to fix iOS deploy

5713a98

Jag96 requested a review from AndrewGable July 30, 2021 21:59

Jag96 requested a review from a team as a code owner July 30, 2021 21:59

Jag96 self-assigned this Jul 30, 2021

MelvinBot removed the request for review from a team July 30, 2021 21:59

Jag96 commented Jul 30, 2021

View reviewed changes

MelvinBot requested a review from aldo-expensify July 30, 2021 21:59

AndrewGable previously approved these changes Jul 30, 2021

View reviewed changes

Jag96 marked this pull request as draft July 30, 2021 22:02

Jag96 added 2 commits July 30, 2021 15:29

update all workflows to macos-11

7f63be8

cocoapods version updated

89520d2

Jag96 dismissed AndrewGable’s stale review via 89520d2 July 30, 2021 22:36

update runs-on value to match accepted schema

ed06e31

roryabraham mentioned this pull request Aug 2, 2021

Fix GitHub Workflow MacOS runners SchemaStore/schemastore#1777

Merged

change back to macos-11

0ac3627

Jag96 marked this pull request as ready for review August 2, 2021 16:50

Jag96 requested a review from roryabraham August 2, 2021 16:50

roryabraham approved these changes Aug 2, 2021

View reviewed changes

AndrewGable approved these changes Aug 2, 2021

View reviewed changes

AndrewGable merged commit 8db44bc into main Aug 2, 2021

AndrewGable deleted the joe-update-xcode-version branch August 2, 2021 17:15

OSBotify mentioned this pull request Aug 2, 2021

Deploy Checklist: Expensify.cash 2021-07-30 #4333

Closed

100 tasks

github-actions bot pushed a commit that referenced this pull request Aug 2, 2021

Merge pull request #4339 from Expensify/joe-update-xcode-version

c0b3d7e

Update XCode to fix iOS deploy (cherry picked from commit 8db44bc)

OSBotify mentioned this pull request Aug 2, 2021

🍒 Cherry pick PR #4339 to staging 🍒 #4373

Merged

OSBotify mentioned this pull request Aug 6, 2021

Deploy Checklist: Expensify.cash 2021-08-06 #4447

Closed

89 tasks

OSBotify mentioned this pull request Aug 11, 2021

Deploy Checklist: Expensify.cash 2021-08-11 #4554

Closed

53 tasks

OSBotify mentioned this pull request Aug 17, 2021

Deploy Checklist: New Expensify 2021-08-17 #4701

Closed

This was referenced Aug 25, 2021

Deploy Checklist: New Expensify 2021-08-25 #4828

Closed

Deploy Checklist: New Expensify 2021-09-01 #4976

Closed

This was referenced Sep 2, 2021

Deploy Checklist: New Expensify 2021-09-01 #5004

Closed

Deploy Checklist: New Expensify 2021-09-03 #5046

Closed

roryabraham mentioned this pull request Aug 1, 2022

[No QA] Upgrade electron builder package to latest version #10159

Merged

93 tasks

OSBotify mentioned this pull request Aug 16, 2022

Deploy Checklist: New Expensify 2022-08-04 #10253

Closed

Conversation

Jag96 commented Jul 30, 2021

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Uh oh!

Jag96 Jul 30, 2021

Choose a reason for hiding this comment

Uh oh!

Jag96 commented Jul 30, 2021

Uh oh!

Jag96 commented Jul 30, 2021

Uh oh!

Jag96 commented Jul 30, 2021

Uh oh!

Jag96 commented Jul 30, 2021

Uh oh!

aldo-expensify commented Jul 31, 2021

Uh oh!

roryabraham commented Aug 2, 2021

Uh oh!

roryabraham commented Aug 2, 2021

Uh oh!

roryabraham commented Aug 2, 2021

Uh oh!

Jag96 commented Aug 2, 2021

Uh oh!

roryabraham left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 2, 2021

Uh oh!

OSBotify commented Aug 2, 2021

Uh oh!

OSBotify commented Aug 6, 2021

Uh oh!

OSBotify commented Aug 6, 2021

Uh oh!

OSBotify commented Aug 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants