Skip to content

Remove policy.submitsTo as it does not exist anymore #43485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristipaval merged 2 commits into from
Jun 26, 2024
Merged

Remove policy.submitsTo as it does not exist anymore #43485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e8919b
Remove policy.submitsTo as it does not exist anymore
flodnv Jun 11, 2024
1fef3bd
Merge remote-tracking branch 'origin/main' into flo_rmsubmitsto
flodnv Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/types/onyx/Policy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1147,9 +1147,6 @@ type Policy = OnyxCommon.OnyxValueWithOfflineFeedback<
/** When the monthly scheduled submit should happen */
autoReportingOffset?: AutoReportingOffset;

/** The accountID of manager who the employee submits their expenses to on paid policies */
submitsTo?: number;

/** The employee list of the policy */
employeeList?: OnyxTypes.PolicyEmployeeList;

Expand Down
1 change: 0 additions & 1 deletion tests/utils/LHNTestUtils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,6 @@ function getFakePolicy(id = '1', name = 'Workspace-Test-001'): Policy {
},
autoReportingOffset: 1,
preventSelfApproval: true,
submitsTo: 123456,
defaultBillable: false,
disabledFields: {defaultBillable: true, reimbursable: false},
approvalMode: 'BASIC',
Expand Down
1 change: 0 additions & 1 deletion tests/utils/collections/policies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ export default function createRandomPolicy(index: number): Policy {
},
autoReportingOffset: 1,
preventSelfApproval: randBoolean(),
submitsTo: index,
outputCurrency: randCurrencyCode(),
role: rand(Object.values(CONST.POLICY.ROLE)),
owner: randEmail(),
Expand Down