Fix: Selecting a language does not update in real time#4366
Fix: Selecting a language does not update in real time#4366iwiznia merged 2 commits intoExpensify:mainfrom
Conversation
|
Pushed another commit to fix a code style issue: 777468d This is ready for review |
|
@kidroca why no tests in ios or web? |
I think you mean "or desktop" I did test on web I'm using a Windows desktop workstation. To run iOS or the Desktop app I need to I've seen others skip it and it seemed fine for the current situation |
|
@iwiznia I had some trouble running the Desktop app, finally after replacing my |
|
Ok will merge in a bit. This will revoke approvals |
|
No need to re-merge, the check was broken and we already merged some PRs like that, so merging. |
(cherry picked from commit 7d842b9)
|
🚀 Cherry-picked to staging in version: 1.0.82-3🚀
|
|
🚀 Deployed to production in version: 1.0.82-7🚀
|
|
🚀 Deployed to staging in version: 1.0.82-8🚀
|
|
🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀
|
Details
This is a continuation PR that addresses a regression from #4253
Fixed Issues
$ #4352
Tests
Texts in app should dynamically change to the selected language
QA Steps
Same as "Tests"
Tested On
Screenshots
Web
Mobile Web
Screen.Recording.2021-08-02.at.22.12.53.mov
Desktop
iOS
Screen.Recording.2021-08-02.at.22.00.49.mov
Android
Android.Emulator.-.Pixel_2_API_29_5554.2021-08-02.18-56-33.mp4