Skip to content

Sage Intacct settings configuration: Export#43776

Merged
yuwenmemon merged 60 commits intoExpensify:mainfrom
software-mansion-labs:war-in/sage-intacct-export-config
Jul 9, 2024
Merged

Sage Intacct settings configuration: Export#43776
yuwenmemon merged 60 commits intoExpensify:mainfrom
software-mansion-labs:war-in/sage-intacct-export-config

Conversation

@war-in
Copy link
Copy Markdown
Contributor

@war-in war-in commented Jun 14, 2024 •
edited
Loading

Details

Fixed Issues

$ #43534
PROPOSAL:

Tests

  1. On account with no preexisting connections to Sage Intacct

  2. Create workspace and go to the "More features" and enable "Accounting"

  3. OldDot - connect to Sage Intacct (use Control plan)

  4. NewDot - go to Accounting tab

  5. You should see Sage Intacct integration

  6. Click on Export entry and see RHP with options:

    • Preferred exporter
    • Export date
    • Reimbursable expenses
    • Non-reimbursable expenses

  7. Click on Preferred exporter entry and see list of all available people (admins)

    1. Select one and be redirected to the previous panel. Default exporter should change to an email of the chosen
      exporter
    2. Go back to the Preferred exporter view and see that selected person is marked as chosen

  8. Repeat same steps for the Export date entry

  9. Repeat same steps for the Reimbursable expenses entry

  10. Go to Non-reimbursable expenses and choose one from the available options.

    1. When you choose Credit card transactions you should see:
    • Credit card account
    • Default vendor
    1. Click on Credit card account and choose a card.
    2. Toggle Default vendor and Default vendor entry should be shown below.
    3. Choose default vendor in that view.
    4. Now change Credit card transactions to Vendor bills.
    5. You should see Default vendor entry only.
    6. Choose default vendor for Vendor bills

Offline tests

QA Steps

  1. On account with no preexisting connections to Sage Intacct

  2. Create workspace and go to the "More features" and enable "Accounting"

  3. OldDot - connect to Sage Intacct (use Control plan)

  4. NewDot - go to Accounting tab

  5. You should see Sage Intacct integration

  6. Click on Export entry and see RHP with options:

    • Preferred exporter
    • Export date
    • Reimbursable expenses
    • Non-reimbursable expenses

  7. Click on Preferred exporter entry and see list of all available people (admins)

    1. Select one and be redirected to the previous panel. Default exporter should change to an email of the chosen
      exporter
    2. Go back to the Preferred exporter view and see that selected person is marked as chosen

  8. Repeat same steps for the Export date entry

  9. Repeat same steps for the Reimbursable expenses entry

  10. Go to Non-reimbursable expenses and choose one from the available options.

    1. When you choose Credit card transactions you should see:
    • Credit card account
    • Default vendor
    1. Click on Credit card account and choose a card.
    2. Toggle Default vendor and Default vendor entry should be shown below.
    3. Choose default vendor in that view.
    4. Now change Credit card transactions to Vendor bills.
    5. You should see Default vendor entry only.
    6. Choose default vendor for Vendor bills

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.July.1.4.mov
Android: mWeb Chrome
Screen.Recording.2024-07-01.at.18.09.50.mov
iOS: Native
Screen.Recording.July.1.2.mov
iOS: mWeb Safari
Screen.Recording.July.1.3.mov
MacOS: Chrome / Safari
Screen.Recording.July.1.mov
MacOS: Desktop
Screen.Recording.July.1.1.mov

@war-in war-in mentioned this pull request Jun 14, 2024
Closed
@war-in war-in changed the title [#Wave-Control - Add Sage Intacct] Settings Configuration in NewDot: Export Sage Intacct settings configuration: Export Jun 18, 2024
SzymczakJ
SzymczakJ reviewed Jun 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@SzymczakJ SzymczakJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from type errors and minor comments LGTM!

@war-in war-in requested a review from SzymczakJ June 25, 2024 10:00
@war-in
Copy link
Copy Markdown
Contributor Author

war-in commented Jul 9, 2024

@yuwenmemon conflicts resolved and translations reverted. It should be mergeable now :)

NikkiWines
NikkiWines requested changes Jul 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things

@war-in war-in requested a review from NikkiWines July 9, 2024 13:42
@war-in
Copy link
Copy Markdown
Contributor Author

war-in commented Jul 9, 2024

@NikkiWines Done!

@war-in
Copy link
Copy Markdown
Contributor Author

war-in commented Jul 9, 2024

@NikkiWines Can I get re-review (approve)? Just to not confuse @yuwenmemon 😅

NikkiWines
NikkiWines requested changes Jul 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of NABs and one other small change 🙇

@war-in
Copy link
Copy Markdown
Contributor Author

war-in commented Jul 9, 2024

@NikkiWines addressed :)

@war-in war-in requested a review from NikkiWines July 9, 2024 14:36
NikkiWines
NikkiWines previously approved these changes Jul 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!! :shipit:

I'll leave the final review for @yuwenmemon

yuwenmemon
yuwenmemon requested changes Jul 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@yuwenmemon yuwenmemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment and we should be good to go!

@war-in
Copy link
Copy Markdown
Contributor Author

war-in commented Jul 9, 2024

@yuwenmemon Done 🚀

@war-in war-in requested a review from yuwenmemon July 9, 2024 15:07
@yuwenmemon yuwenmemon merged commit 17c99a1 into Expensify:main Jul 9, 2024
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jul 9, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot mentioned this pull request Jul 10, 2024
Closed
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jul 10, 2024

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.6-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jul 10, 2024

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.6-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@lanitochka17 lanitochka17 mentioned this pull request Jul 10, 2024
Closed
6 tasks
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jul 11, 2024

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jul 11, 2024

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jul 15, 2024

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jul 17, 2024

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@war-in war-in deleted the war-in/sage-intacct-export-config branch April 11, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuwenmemon yuwenmemon yuwenmemon approved these changes

@NikkiWines NikkiWines NikkiWines left review comments

+2 more reviewers

@SzymczakJ SzymczakJ SzymczakJ left review comments

@hungvu193 hungvu193 hungvu193 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@war-in @yuwenmemon @hungvu193 @dannymcclain @NikkiWines @jamesdeanexpensify @OSBotify @SzymczakJ