Remove unused propType for CollapsibleSection #4386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgolen
requested changes
Aug 3, 2021
Contributor
Author
|
@tgolen updated! |
tgolen
approved these changes
Aug 11, 2021
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Aug 12, 2021
Contributor
Contributor
|
🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marcaaron will you please review this?
Details
This PR removes an unused propType from the CollapsibleSection component. This is a follow-up to #3879 (review).
Fixed Issues
Follow up to #3879 (review)
Tests
The easiest way to get to the Terms Page without going through the entire OnFido flow is to update the following lines locally:
+button and selectingNew ChatAll Expensify Payments account feesdropdown, and that it's initial state is closedNote, there is an issue where the enable-payments page only shows up the first time you view it until you sign out (slack post)
QA Steps
N/A
Tested On
Screenshots
Screenshots
Mobile
Web/Desktop