handle navigation when reportID isn't valid#4387
Merged
Jag96 merged 3 commits intoExpensify:mainfrom Aug 5, 2021
Merged
Conversation
Jag96
reviewed
Aug 3, 2021
Contributor
Jag96
left a comment
Jag96
left a comment
There was a problem hiding this comment.
Tests well, just added one comment about a potential improvement
Jag96
suggested changes
Aug 5, 2021
Contributor
Jag96
left a comment
Jag96
left a comment
There was a problem hiding this comment.
Looks good, just one request
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Aug 5, 2021
Contributor
|
🚀 Deployed to staging in version: 1.0.82-8🚀
|
Contributor
|
🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
(comment)
Fixed Issues
$ #4319
Tests || ### QA Steps
r/in the URLTested On
Screenshots
Web
prWeb.mp4
Mobile Web
mWeb.mp4
Desktop
iOS
Android