Skip to content

[CP Staging] Revert "fix: CI upload source maps when deploying a new app version" #43935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 1 commit into from
Jun 18, 2024
Merged

[CP Staging] Revert "fix: CI upload source maps when deploying a new app version" #43935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/platformDeploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ jobs:
uses: actions/upload-artifact@v3
with:
name: android-sourcemap
path: android/app/build/generated/sourcemaps/react/productionRelease/index.android.bundle.map
path: android/app/build/generated/sourcemaps/react/release/*.map

- name: Upload Android version to GitHub artifacts
if: ${{ !fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }}
Expand Down
5 changes: 0 additions & 5 deletions ios/.xcode.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,3 @@
# For example, to use nvm with brew, add the following line
# . "$(brew --prefix nvm)/nvm.sh" --no-use
export NODE_BINARY=$(command -v node)

# Provide a sourcemap path so that in release builds a source map file will be
# created at the specified location.
# (RN's default behaviour on iOS is to skip creating a sourcemap file):
export SOURCEMAP_FILE="$(pwd)/../main.jsbundle.map";
2 changes: 1 addition & 1 deletion workflow_tests/assertions/platformDeployAssertions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ function assertAndroidJobExecuted(workflowResult: Step[], didExecute = true, isP
steps.push(
createStepAssertion('Archive Android sourcemaps', true, null, 'ANDROID', 'Archiving Android sourcemaps', [
{key: 'name', value: 'android-sourcemap'},
{key: 'path', value: 'android/app/build/generated/sourcemaps/react/productionRelease/index.android.bundle.map'},
{key: 'path', value: 'android/app/build/generated/sourcemaps/react/release/*.map'},
]),
);
if (!isProduction) {
Expand Down