Skip to content

Don't show loading state in workspace setup button #4401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-mechler merged 1 commit into from
Aug 4, 2021
Merged

Don't show loading state in workspace setup button #4401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/pages/workspace/WorkspaceCardPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@ const WorkspaceCardPage = ({
success
large
text={buttonText}
isLoading={reimbursementAccount.loading}
Copy link
Contributor

@alex-mechler alex-mechler Aug 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any case where this can be true, but the modal is not open?

Copy link
Contributor Author

@stitesExpensify stitesExpensify Aug 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, not that I know of / could figure out

/>
</View>
</View>
Expand Down