[#Wave-Control: Add NetSuite]: Top-level Subsidiary selection by mananjadhav · Pull Request #44038 · Expensify/App

mananjadhav · 2024-06-19T20:00:39Z

Details

Covers the implementation of Top-level subsidiary config page.

This is one of the first FE PRs for NetSuite without the proper auth flow integrated. Hence, to get this working we'll need to have a few pre-requisites:

Collect workspace with accounting enabled.
NetSuite beta enabled for the user. You can return true in the canUseNetSuiteIntegration method.
Setup the netsuite data linked in the comment here for the given workspace as connections: {netsuite: <linkedjson>}.

One way I did the setup is calling Onyx.merge with useEffect on any FE component.
   useEffect(() => {
       Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}76A10AB364F95DA0`, {"connections":{"netsuite":{"accountID":"TSTDRV1668486", ....})
   }, []);

Fixed Issues

$ #43435
PROPOSAL:

Tests

Open the app with the pre-setup workspace.
Go to Accounting from the LHS
Verify that you're able to see Net Suite in the active connections along with the Oracle NetSuite logo.
Verify that you're able to see the Subsidiary list item below NetSuite title along with the subsidiary listed as Honeycomb Mfg. (based on the test data imported)
Click on the item, and see that it opens the list of subsidiaries in RHS.
Confirm the title and the description of the screen.
Click on one of the subsidiaries.
It should take you back to the Accounting screen, with subsidiary listed based on the selection in step 7.

Verify that no errors appear in the JS console

Offline tests

Open the app with the pre-setup workspace.
Go to Accounting from the LHS
Go offline.
Verify that you're able to see Net Suite in the active connections along with the Oracle NetSuite logo.
Verify that you're able to see the Subsidiary list item below NetSuite title along with the subsidiary listed as Honeycomb Mfg. (based on the test data imported)
Click on the item, and see that it opens the list of subsidiaries in RHS.
Confirm the title and the description of the screen.
Click on one of the subsidiaries.
It should take you back to the Accounting screen, with subsidiary listed based on the selection in step 8 but in grey disabled color.

QA Steps

Same as Test Steps. Additionally do a sanity on list pages such as Report, Search that the list and scroll behavior is not impacted.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-net-suite-subsidiary.mov

Android: mWeb Chrome

mweb-chrome-net-suite-subsidiary.mov

iOS: Native

ios-net-suite-subsidiary.mov

iOS: mWeb Safari

mweb-safari-net-suite-subsidiary.mov

MacOS: Chrome / Safari

Basic Test

web-net-suite-subsidiary.mp4

Offline Behavior

web-net-suite-subsidiary-offline_gylZqRMq.mp4

Web Spanish Translation

Error handling

web-net-suite-subsidiary-error.mov

MacOS: Desktop

desktop-net-suite-subsidiary.mov

…dit-last-message" This reverts commit 478db52, reversing changes made to bb14c99.

…edit-last-message" This reverts commit 747fe19.

…bsidiary-select

src/libs/actions/connections/netsuite.ts

shubham1206agra · 2024-06-21T06:52:14Z

src/libs/actions/connections/netsuite.ts

+                        netsuite: {
+                            options: {
+                                config: {
+                                    subsidiary,


You don't need this as this will be redundant.

Will keep this, and replace once your PR is merged for the common method.

shubham1206agra · 2024-06-21T06:52:47Z

src/libs/actions/connections/netsuite.ts

+                        netsuite: {
+                            options: {
+                                config: {
+                                    subsidiary,


Suggested change

subsidiary,

mananjadhav · 2024-06-25T14:26:08Z

The console error seems unrelated to changes in this one and exists already. I'll first fix the SelectionScreen as I am at the airport. If time permits I'll try to fix the console.error.

src/pages/workspace/accounting/netsuite/NetSuiteSubsidiarySelector.tsx

shubham1206agra · 2024-06-25T15:15:26Z

src/pages/workspace/accounting/netsuite/NetSuiteSubsidiarySelector.tsx

+import type SCREENS from '@src/SCREENS';
+import type {NetSuiteSubsidiary} from '@src/types/onyx/Policy';
+
+type NetSuiteSubsidiarySelectorProps = WithPolicyConnectionsProps & StackScreenProps<SettingsNavigatorParamList, typeof SCREENS.WORKSPACE.ACCOUNTING.NETSUITE_SUBSIDIARY_SELECTOR>;


I feel this is unecessary.

shubham1206agra · 2024-06-25T15:25:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-06-25.at.5.51.33.PM.mov

iOS: Native

Screen.Recording.2024-06-25.at.6.57.13.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-06-25.at.5.46.08.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-25.at.5.44.15.PM.mov

MacOS: Desktop

Screen.Recording.2024-06-25.at.6.46.28.PM.mov

mananjadhav · 2024-06-25T15:34:35Z

Revised screencasts with SelectionScreen.

Web Also contains empty screen screenshot.

web-updated-screencast_jd4dYEG5.mp4

iOS: Doesn't have the console.error so I removed the SelectionList prop that I added for nested view.

ios-updated-screencast.mov

yuwenmemon

Nice!

OSBotify · 2024-06-25T22:01:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-03T19:39:09Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T10:57:44Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ikevin127 · 2024-09-24T01:14:26Z

src/pages/workspace/accounting/PolicyAccountingPage.tsx

+            ...(policyConnectedToNetSuite && !shouldShowSynchronizationError
+                ? [
+                      {
+                          description: translate('workspace.netsuite.subsidiary'),
+                          iconRight: Expensicons.ArrowRight,
+                          title: netSuiteSelectedSubsidiary,
+                          wrapperStyle: [styles.sectionMenuItemTopDescription],
+                          titleStyle: styles.fontWeightNormal,
+                          shouldShowRightIcon: netSuiteSubsidiaryList.length > 1,
+                          shouldShowDescriptionOnTop: true,
+                          pendingAction: policy?.connections?.netsuite?.options?.config?.pendingFields?.subsidiary,
+                          brickRoadIndicator: policy?.connections?.netsuite?.options?.config?.errorFields?.subsidiary ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined,
+                          onPress: () => {
+                              if (!(netSuiteSubsidiaryList.length > 1)) {
+                                  return;
+                              }
+                              Navigation.navigate(ROUTES.POLICY_ACCOUNTING_NETSUITE_SUBSIDIARY_SELECTOR.getRoute(policyID));
+                          },
+                      },
+                  ]
+                : []),


Looks like this part of the logic led to the following issue:

[CHECKLIST] [$250] NetSuite - "Subsidiary" shows while the connection is syncs for the first time #48274 (comment)

Which we solved by returning empty object when there's no value for subsidiary, more details in issue proposal.

mananjadhav added 27 commits June 7, 2024 02:56

Revert "Merge pull request Expensify#42965 from suneox/40767-handle-e…

747fe19

…dit-last-message" This reverts commit 478db52, reversing changes made to bb14c99.

Reapply "Merge pull request Expensify#42965 from suneox/40767-handle-…

8c0912a

…edit-last-message" This reverts commit 747fe19.

Merge branch 'main' of github.com:mananjadhav/App

2ab267e

Merge branch 'main' of github.com:mananjadhav/App

b335e64

Merge branch 'main' of github.com:mananjadhav/App

e8c4fb5

feat: net suite setup

5224cb9

feat: navigation types

f288173

feat: page setup with options

b51c85a

fix: default selection

95089ff

fix: routing

424495d

feat: show selected subsidiary

c8185c8

style: lint fixes

007d762

refactor: remove console.log

577dc58

feat: added write command

68c865c

Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-su…

855c930

…bsidiary-select

refactor: rename type

2a4add9

refactor: lint fixes

4461ff2

Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-su…

6fc7b09

…bsidiary-select

feat: added icon and es content

88ec924

fix: added fallback

d563a73

refactor: rename net_suite identifier

208b4b9

feat: added api types

bd7973a

feat: modify optimistic data

0faf015

feat: added api call

d66f59d

fix: param name

0664aa6

Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-su…

8fa3a78

…bsidiary-select

Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-su…

8c1c8d6

…bsidiary-select

shubham1206agra reviewed Jun 21, 2024

View reviewed changes

src/libs/actions/connections/netsuite.ts Outdated Show resolved Hide resolved

shubham1206agra reviewed Jun 21, 2024

View reviewed changes

mananjadhav added 2 commits June 25, 2024 17:23

fix: go back

1132bb0

refactor: run prettier

16ee3e2

mananjadhav added 5 commits June 25, 2024 17:41

refactor: use selectionscreen

0bb8d5a

refactor: api call fixes

a977826

refactor: import lint error

0fe7e06

refactor: rename methods and error conditions

ac62d2f

fix: Spanish translation

e1f9e11

shubham1206agra reviewed Jun 25, 2024

View reviewed changes

src/pages/workspace/accounting/netsuite/NetSuiteSubsidiarySelector.tsx Outdated Show resolved Hide resolved

mananjadhav added 3 commits June 25, 2024 18:08

refactor: added fallback

e0b782a

fix: rollback unwanted prop

bb8f94b

fix: remove extra space

2a9b743

shubham1206agra reviewed Jun 25, 2024

View reviewed changes

mananjadhav added 2 commits June 25, 2024 18:16

fix: netsuite name

6be111f

refactor: remove unwanted types

01cac87

fix: lint errors

fc16c01

shubham1206agra approved these changes Jun 25, 2024

View reviewed changes

yuwenmemon approved these changes Jun 25, 2024

View reviewed changes

yuwenmemon merged commit a6ba6ce into Expensify:main Jun 25, 2024

github-actions bot mentioned this pull request Jun 27, 2024

Deploy Checklist: New Expensify 2024-06-27 #44575

Closed

85 tasks

lanitochka17 mentioned this pull request Jun 28, 2024

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Netsuite - Categories copy mentions "Xero settings" instead of "NetSuite" settings #44591

Closed

6 tasks

melvin-bot bot mentioned this pull request Jul 3, 2024

[HOLD for payment 2024-07-10] [#Wave-Control: Add NetSuite] Settings Configuration in NewDot: Top-Level Subsidiary Selector #43435

Closed

shawnborton mentioned this pull request Aug 23, 2024

[Search v2.2] Update Trips empty state on Search to avoid double empty state #47937

Closed

ikevin127 reviewed Sep 24, 2024

View reviewed changes

ikevin127 mentioned this pull request Sep 24, 2024

[CHECKLIST] [$250] NetSuite - "Subsidiary" shows while the connection is syncs for the first time #48274

Closed

6 tasks

Conversation

mananjadhav commented Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

shubham1206agra Jun 21, 2024

Choose a reason for hiding this comment

Uh oh!

mananjadhav Jun 21, 2024

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Jun 21, 2024

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

shubham1206agra Jun 25, 2024

Choose a reason for hiding this comment

Uh oh!

mananjadhav Jun 25, 2024

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented Jun 25, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav commented Jun 25, 2024

Uh oh!

yuwenmemon left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jun 25, 2024

Uh oh!

OSBotify commented Jul 3, 2024

Uh oh!

OSBotify commented Jul 10, 2024

Uh oh!

ikevin127 Sep 24, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

mananjadhav commented Jun 19, 2024 •

edited

Loading

mananjadhav commented Jun 25, 2024 •

edited

Loading