Fix Password Forms Header Title#4410
Conversation
|
@Jag96 PR Raised. Can someone verify the Spanish translations? I've picked from Google translate. |
src/languages/en.js
Outdated
| phrase4: 'Welcome back to the New Expensify! Please set your password.', | ||
| phrase5: 'Welcome back to the New Expensify! Please enter your password.', |
There was a problem hiding this comment.
Let's move these to the setPasswordPage translations here. Let's also give them more descriptive names like setYourPassword and enterYourPassword instead.
There was a problem hiding this comment.
I've moved phrase4 to setPasswordPage.passwordFormTitle. phrase5 is retained in welcomeText as it is a part of the SiginInPage flow. Let me know if you still want me to change it?
…ssword-title-label
jasperhuangg
left a comment
There was a problem hiding this comment.
Looks good! I heard back about the translations, so I'll commit those and get this merged, thanks!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging in version: 1.0.82-8🚀
|
|
🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀
|
@Jag96 Can you please review?
Details
welcomeTextwelcomeTextprop to all the forms necessarywelcomeTextphrasesFixed Issues
$ #4315
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android