Attempt at fixing race

[chiragsalian]

cc @parasharrajat for some reason I cant add you as a reviewer.

Details

Fixed Issues

$ #4388 (comment)

Tests

1. Update this line to be const timezone = {automatic: true, selected: 'Asia/Kolkata'};.
2. Tested logging out and logging in on simulator and web and confirmed i didn't see any Cannot read property 'replace' of undefined during log out and log in.

QA Steps

Steps mentioned in issue - #4388 (comment)

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[chiragsalian]

Besides moving the block i also added this bit so that when we log out if this is null it just returns early since there is no reason to proceed with val is empty.

[parasharrajat]

There is one more thing, this should not run when the user is logged out. But it's fine you have null check on val which should cover this case as well.

[github-actions]

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

[chiragsalian]

oh jest is failing. But its passing for me locally 🤔
weird, let me restart it and see if it helps.

Edit: Its failing for me locally as weird. Weird i could've sworn i ran npm run test yesterday and it passed. Investigating.

[chiragsalian]

Looks like I was able to resolve the problem with jest. I had to move the blocks back to authScreens since there were more race conditions occurring in jest causing it to fail. Atm having the code in authScreens with an early return seems like an easy fix so I think it's best to try it out first.

[NikkiWines]

Looks good 👍

[chiragsalian]

Luke seems to be offline and this is a deploy blocker. Self merging so that we can test if this resolves the blocker.

[OSBotify]

🚀 Cherry-picked to staging in version: 1.0.82-4🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production in version: 1.0.82-7🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging in version: 1.0.82-8🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅