Fix: incorrect prop name passed for locale#4419
Merged
Luke9389 merged 1 commit intoExpensify:mainfrom Aug 5, 2021
Merged
Conversation
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
kidroca
force-pushed
the
kidroca/withLocalize-pass-locale
branch
2 times, most recently
from
e50c040 to
bcce2cf
Compare
kidroca
force-pushed
the
kidroca/withLocalize-pass-locale
branch
from
bcce2cf to
ac4c51b
Compare
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Aug 6, 2021
Contributor
|
🚀 Deployed to staging in version: 1.0.82-8🚀
|
Contributor
|
🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Update to pass
preferredLocaledown to children as we did before@aman-atg thanks for the investigation: #4404 (comment)
Fixed Issues
$ #4404
Tests
QA Steps
Same as above
Tested On
Screenshots
Web
Screen.Recording.2021-08-05.at.13.10.35.mov
Mobile Web
Screen.Recording.2021-08-05.at.13.13.02.mov
Desktop
Screen.Recording.2021-08-05.at.13.06.39.mov
iOS
Android