Skip to content

fix: outline on sign in page#4424

Merged
Julesssss merged 2 commits intoExpensify:mainfrom
parasharrajat:ui
Aug 6, 2021
Merged

fix: outline on sign in page#4424
Julesssss merged 2 commits intoExpensify:mainfrom
parasharrajat:ui

Conversation

@parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Aug 5, 2021

Details

#4328 (comment)

Fixed Issues

$ Fixes #4328

Tests | QA Steps

  1. Open Sign In page in all devices and border should be shown on focusing over the input.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS (Does not have Outline issue)
  • Android (Does not have Outline issue)

Screenshots

Web | Desktop

outline-w

Mobile Web

outline-m

iOS

Android

@parasharrajat
Copy link
Member Author

It seems that Package-lock.json was not updated during the upgrade of e-common.

@parasharrajat parasharrajat changed the title fix: outline on singin page fix: outline on sign in page Aug 5, 2021
@parasharrajat parasharrajat marked this pull request as ready for review August 5, 2021 19:45
@parasharrajat parasharrajat requested a review from a team as a code owner August 5, 2021 19:45
@MelvinBot MelvinBot requested review from Julesssss and removed request for a team August 5, 2021 19:45
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on iOS, mobile web and web

@Julesssss Julesssss merged commit 933704a into Expensify:main Aug 6, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to staging in version: 1.0.82-9🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[HOLD for payment on Friday 13th 👻 ] mWeb - Focus on email box is not correctly displayed on the sides of the text input

3 participants