Create usePaginatedReportActions hook by roryabraham · Pull Request #44412 · Expensify/App

roryabraham · 2024-06-25T21:42:50Z

Details

This PR is part of #41962, done in the hopes of reducing the diff, avoiding conflicts, and reducing the likelihood of regressions.

Fixed Issues

$ see the list in #41962

Tests / QA Steps

Open a report, verify reportActions load as expected.
Scroll back in the history, verify you can load more chats.
Link to a specific comment in a report, verify reportActions load as expected.

Verify that no errors appear in the JS console

Offline tests

n/a

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

# Conflicts: # src/pages/home/ReportScreen.tsx

roryabraham · 2024-06-26T00:01:37Z

tests/ui/UnreadIndicatorsTest.tsx

+        expect(unreadIndicator).toHaveLength(1);
+
+        // Leave a comment as the current user and verify the indicator is not removed
+        const reportActionsBefore = (await TestHelper.onyxGet(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${REPORT_ID}`)) as Record<string, ReportAction>;


Lines 535 -> 547 are the most important changes in this test file - the rest of it is just using async/await instead of promise chains without further changes.

These lines simulate a server response setting a correct value for previousReportActionID when our action is finalized.

It's not 100% clear why this wasn't needed before, but it seems like using useOnyx results in faster re-renders in a test environment, and that test was a false positive before just testing the content we had on the screen before calling Report.addComment.

Updated the test to verify the new comment is visible on the screen after it's added, to prevent false positives in the future.

melvin-bot · 2024-06-26T03:13:29Z

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/home/ReportScreen.tsx

ishpaul777 · 2024-06-27T15:54:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Record_2024-06-28-01-03-48.mp4

Android: mWeb Chrome

Record_2024-06-28-00-21-28.mp4

Record_2024-06-28-00-31-46.mp4

iOS: Native

Screen.Recording.2024-06-27.at.11.14.28.PM-1.mov

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Plus.-.2024-06-27.at.23.27.45-1.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-27.at.11.10.29.PM-1.mov

MacOS: Desktop

Screen.Recording.2024-06-27.at.11.56.51.PM-1.mov

ishpaul777 · 2024-06-27T16:00:54Z

This issue #41962 (comment) seems to be reproducable on this branch as well

Bug: Attachements not loading and when click on loading preview from attachement , app crashes

Screen.Recording.2024-06-26.at.10.17.30.PM.mov

edit: Repro on main also

ishpaul777 · 2024-06-27T16:07:56Z

Looks like this is reproducable on main also not a blocker for this or main PR. Its coming from #42592, setting USE_REACT_STRICT_MODE: false in CONFIG.TS fixes this issue

src/pages/home/ReportScreen.tsx

melvin-bot · 2024-06-27T18:58:51Z

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-06-27T18:58:54Z

🎯 @ishpaul777, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #44567.

# Conflicts: # src/pages/ReportDetailsPage.tsx

yuwenmemon · 2024-06-27T21:59:14Z

src/hooks/usePaginatedReportActions.ts

+ */
+function usePaginatedReportActions(reportID?: string, reportActionID?: string) {
+    // Use `||` instead of `??` to handle empty string.
+    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing


Why do we even have this rule? This is like the 3rd time I've seen it dismissed today.

jasperhuangg · 2024-07-01T22:50:45Z

^ Not saying this is causing any problems yet, there's just a deploy blocker that can't be reproduced on my local staging env (not sure why) so I'm trying to see if any adhoc builds work

jasperhuangg · 2024-07-01T23:22:09Z

Sorry to say that this is causing #44583 :/ Gonna get a revert up

OSBotify · 2024-07-03T19:41:45Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T11:01:35Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

roryabraham added 4 commits June 25, 2024 14:42

Create usePaginatedReportActions hook

1fd8756

Merge branch 'main' into Rory-DRYReportActionsSorting

bf90268

# Conflicts: # src/pages/home/ReportScreen.tsx

fix test

7c42c89

Finish comment

b6f8b76

roryabraham changed the title ~~[WIP] Create usePaginatedReportActions hook~~ Create usePaginatedReportActions hook Jun 25, 2024

roryabraham self-assigned this Jun 25, 2024

roryabraham commented Jun 26, 2024

View reviewed changes

Verify new comment is on screen

3dc0a33

roryabraham marked this pull request as ready for review June 26, 2024 03:13

roryabraham requested a review from a team as a code owner June 26, 2024 03:13

melvin-bot bot removed the request for review from a team June 26, 2024 03:13

melvin-bot bot requested a review from stitesExpensify June 26, 2024 03:13

roryabraham mentioned this pull request Jun 26, 2024

Client side pagination gap detection #41962

Merged

60 tasks

ishpaul777 reviewed Jun 26, 2024

View reviewed changes

src/pages/home/ReportScreen.tsx Show resolved Hide resolved

src/pages/home/ReportScreen.tsx Show resolved Hide resolved

roryabraham added 2 commits June 27, 2024 08:14

Merge branch 'main' into Rory-DRYReportActionsSorting

8a43984

Remove isLinkedMessageAvailable local var

eab1ab4

roryabraham requested a review from ishpaul777 June 27, 2024 15:22

Merge branch 'main' into Rory-DRYReportActionsSorting

8289977

This comment was marked as resolved.

Sign in to view

ishpaul777 reviewed Jun 27, 2024

View reviewed changes

src/pages/home/ReportScreen.tsx Outdated Show resolved Hide resolved

fix bad boolean flip

f4e6750

ishpaul777 approved these changes Jun 27, 2024

View reviewed changes

melvin-bot bot requested a review from blimpich June 27, 2024 18:58

melvin-bot bot mentioned this pull request Jun 27, 2024

[PAID] Payment issue for E/App PR#44412 #44567

Closed

roryabraham added 2 commits June 27, 2024 14:02

Merge branch 'main' into Rory-DRYReportActionsSorting

fd6cf82

Merge branch 'main' into Rory-DRYReportActionsSorting

cf0de00

# Conflicts: # src/pages/ReportDetailsPage.tsx

yuwenmemon approved these changes Jun 27, 2024

View reviewed changes

yuwenmemon merged commit 61399f5 into main Jun 27, 2024

yuwenmemon deleted the Rory-DRYReportActionsSorting branch June 27, 2024 22:00

github-actions bot mentioned this pull request Jun 27, 2024

Deploy Checklist: New Expensify 2024-06-27 #44575

Closed

85 tasks

tsa321 mentioned this pull request Jun 28, 2024

[HOLD for payment 2024-07-10] [$250] Chat does not scroll to the last message when a new message received #43600

Closed

6 tasks

jasperhuangg mentioned this pull request Jul 1, 2024

App crashes when attempting to open an #admins room #44583

Closed

6 tasks

jasperhuangg mentioned this pull request Jul 1, 2024

Revert "Create usePaginatedReportActions hook" #44706

Closed

bernhardoj mentioned this pull request Jul 2, 2024

Fix paid system message is not highlighted when clicking on the message link #44719

Merged

50 tasks

roryabraham mentioned this pull request Jul 9, 2024

Create usePaginatedReportActions hook (round 2) #45112

Merged

49 tasks

Conversation

roryabraham commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests / QA Steps

Offline tests

PR Author Checklist

Screenshots/Videos

Uh oh!

roryabraham Jun 26, 2024

Choose a reason for hiding this comment

Uh oh!

roryabraham Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Jun 26, 2024

Uh oh!

Uh oh!

Uh oh!

ishpaul777 commented Jun 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ishpaul777 commented Jun 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented Jun 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

melvin-bot bot commented Jun 27, 2024

Uh oh!

melvin-bot bot commented Jun 27, 2024

Uh oh!

yuwenmemon Jun 27, 2024

Choose a reason for hiding this comment

Uh oh!

jasperhuangg commented Jul 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasperhuangg commented Jul 1, 2024

Uh oh!

OSBotify commented Jul 3, 2024

Uh oh!

OSBotify commented Jul 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

roryabraham commented Jun 25, 2024 •

edited

Loading

roryabraham Jun 26, 2024 •

edited

Loading

ishpaul777 commented Jun 27, 2024 •

edited

Loading

ishpaul777 commented Jun 27, 2024 •

edited

Loading

ishpaul777 commented Jun 27, 2024 •

edited

Loading

jasperhuangg commented Jul 1, 2024 •

edited

Loading