fix keyboard overlap composer by huult · Pull Request #44428 · Expensify/App

huult · 2024-06-26T06:33:07Z

Details

Fixed Issues

$ #43615
PROPOSAL: #43615 (comment)

Tests

Open any chat
Send 5 messages
Long press on the first message and select Edit comment
Add few new lines using Enter key
Verify the composer is fully visible

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open any chat
Send 5 messages
Long press on the first message and select Edit comment
Add few new lines using Enter key
Verify the composer is fully visible

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen_Recording_20240627_200038_New.Expensify.Dev.mp4

Android: mWeb Chrome

Screen.Recording.2024-06-26.at.10.26.30.mov

iOS: Native

Screen.Recording.2024-06-26.at.00.15.59.mov

iOS: mWeb Safari

Screen.Recording.2024-06-26.at.09.44.06.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-26.at.13.20.52.mov

MacOS: Desktop

Screen.Recording.2024-06-26.at.00.23.38.mov

melvin-bot · 2024-06-26T06:33:12Z

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2024-06-26T06:33:18Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

huult · 2024-06-26T06:40:22Z

I have read the CLA Document and I hereby sign the CLA

suneox · 2024-06-28T15:36:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-06-29.at.00.26.50.mov

Android: mWeb Chrome

Screen.Recording.2024-06-29.at.00.29.01.mov

iOS: Native

Screen.Recording.2024-06-29.at.00.32.57.mov

iOS: mWeb Safari

Screen.Recording.2024-06-29.at.00.32.04.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-29.at.00.35.30.mov

MacOS: Desktop

Screen.Recording.2024-06-29.at.00.36.06.mov

suneox · 2024-06-28T18:02:43Z

src/pages/home/report/ReportActionItemMessageEdit.tsx

The callback methods have to be named for what the method does so we have to update callback func ST like that

Suggested change

onLayout={reportActionItemEventHandler.onLayout(reportScrollManager, index)}

onLayout={reportActionItemEventHandler.handleComposerLayoutChange(reportScrollManager, index)}

@suneox I have updated this change as you suggested. Can you check it?

suneox

LGTM

puneetlath · 2024-07-01T14:21:53Z

src/pages/home/report/ReportActionItemMessageEdit.tsx

For my understanding. Why do we only import the index.android part?

hi @puneetlath My mistake, auto-import in my IDE. I have updated it. Can you check it again?

puneetlath · 2024-07-01T16:16:06Z

src/pages/home/report/ReportActionItemMessageEdit.tsx

Don't we typically just import like this?

Suggested change

import reportActionItemEventHandler from '@libs/ReportActionItemEventHandler/index';

import reportActionItemEventHandler from '@libs/ReportActionItemEventHandler';

I updated it as you suggested. Do you have any more feedback?

puneetlath · 2024-07-01T16:27:48Z

@huult looks like you have some unsigned commits, so that check is failing.

huult · 2024-07-01T17:00:02Z

Hi @puneetlath , @suneox , I have fixed everything. Can you double-check? Thank you!

puneetlath · 2024-07-01T17:08:02Z

Some commits are still un-signed.

huult · 2024-07-01T18:54:50Z

Hi @puneetlath , Sorry for that. My signing tool had an error, so the merges on my branch were not signed. I rebased the commits into one and resolved the signing issue. Could you please check it again?
Regarding the pipeline failure, it failed due to a package patch failure.

puneetlath · 2024-07-01T20:35:27Z

Ok cool thanks. @suneox mind giving it a quick re-review/test? And then I can final-review/merge.

suneox · 2024-07-02T03:48:43Z

Ok cool thanks. @suneox mind giving it a quick re-review/test? And then I can final-review/merge.

Sure, I'll test again on all platform in few hours

suneox · 2024-07-02T04:03:12Z

@huult Could you please merge latest main to fix an issue patch-package when install package?

huult · 2024-07-02T04:34:55Z

@suneox it's done

suneox · 2024-07-02T06:23:34Z

@puneetlath I have tested it, and it still works on the latest main branch.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-02.at.13.00.50.mov

Android: mWeb Chrome

Screen.Recording.2024-07-02.at.13.07.31.mov

iOS: Native

Screen.Recording.2024-07-02.at.13.12.24.mov

iOS: mWeb Safari

Screen.Recording.2024-07-02.at.13.15.23.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-02.at.12.56.57.mov

MacOS: Desktop

Screen.Recording.2024-07-02.at.12.58.47.mov

OSBotify · 2024-07-02T15:04:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-03T20:02:00Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.4-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-04T22:14:27Z

🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-10T11:01:47Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T20:21:05Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

linhvovan29546 · 2025-09-25T10:11:16Z

src/pages/home/report/ReportActionItemMessageEdit.tsx

                                }
                                setShouldShowComposeInputKeyboardAware(true);
                            }}
+                            onLayout={reportActionItemEventHandler.handleComposerLayoutChange(reportScrollManager, index)}


This caused the app to automatically scroll to the edit input instead of the bottom of the list. We have applied the fix here. #70219

huult requested a review from a team as a code owner June 26, 2024 06:33

melvin-bot bot requested review from suneox and removed request for a team June 26, 2024 06:33

huult marked this pull request as draft June 26, 2024 07:04

huult marked this pull request as ready for review June 27, 2024 08:36

huult marked this pull request as draft June 27, 2024 08:39

huult marked this pull request as ready for review June 27, 2024 18:09

huult mentioned this pull request Jun 27, 2024

[HOLD for payment 2024-07-17] [$250] Android – Chat – The keyboard overlap composer box when editing mid-message adding new lines #43615

Closed

6 tasks

suneox reviewed Jun 28, 2024

View reviewed changes

suneox approved these changes Jun 29, 2024

View reviewed changes

melvin-bot bot requested a review from puneetlath June 29, 2024 14:22

puneetlath reviewed Jul 1, 2024

View reviewed changes

puneetlath requested changes Jul 1, 2024

View reviewed changes

puneetlath previously approved these changes Jul 1, 2024

View reviewed changes

huult dismissed puneetlath’s stale review via 43f28d7 July 1, 2024 16:50

huult requested review from puneetlath and suneox July 1, 2024 16:56

huult force-pushed the 43615-keyboard-overlap-edit-message branch 2 times, most recently from e57c19e to 7e0c8a6 Compare July 1, 2024 18:28

fix keyboard overlap composer

50a4af1

huult force-pushed the 43615-keyboard-overlap-edit-message branch from 7e0c8a6 to 50a4af1 Compare July 2, 2024 04:14

suneox approved these changes Jul 2, 2024

View reviewed changes

puneetlath approved these changes Jul 2, 2024

View reviewed changes

puneetlath merged commit 3cbfc54 into Expensify:main Jul 2, 2024

github-actions bot mentioned this pull request Jul 3, 2024

Deploy Checklist: New Expensify 2024-07-03 #44782

Closed

dmkt9 mentioned this pull request Sep 9, 2025

[Due for payment 2025-09-30] [$250] Attachment - User is scrolled to the draft instead of latest shared image #70219

Closed

8 tasks

linhvovan29546 reviewed Sep 25, 2025

View reviewed changes

blazejkustra mentioned this pull request Feb 20, 2026

[BATCH 6] Migrate scroll operations #83067

Open

	onLayout={reportActionItemEventHandler.onLayout(reportScrollManager, index)}
	onLayout={reportActionItemEventHandler.handleComposerLayoutChange(reportScrollManager, index)}

	import reportActionItemEventHandler from '@libs/ReportActionItemEventHandler/index';
	import reportActionItemEventHandler from '@libs/ReportActionItemEventHandler';

Conversation

huult commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 26, 2024

Uh oh!

github-actions bot commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

huult commented Jun 26, 2024

Uh oh!

suneox commented Jun 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

suneox Jun 28, 2024

Choose a reason for hiding this comment

Uh oh!

huult Jun 29, 2024

Choose a reason for hiding this comment

Uh oh!

suneox left a comment

Choose a reason for hiding this comment

Uh oh!

puneetlath Jul 1, 2024

Choose a reason for hiding this comment

Uh oh!

huult Jul 1, 2024

Choose a reason for hiding this comment

Uh oh!

puneetlath Jul 1, 2024

Choose a reason for hiding this comment

Uh oh!

huult Jul 1, 2024

Choose a reason for hiding this comment

Uh oh!

puneetlath commented Jul 1, 2024

Uh oh!

huult commented Jul 1, 2024

Uh oh!

puneetlath commented Jul 1, 2024

Uh oh!

huult commented Jul 1, 2024

Uh oh!

puneetlath commented Jul 1, 2024

Uh oh!

suneox commented Jul 2, 2024

Uh oh!

suneox commented Jul 2, 2024

Uh oh!

huult commented Jul 2, 2024

Uh oh!

suneox commented Jul 2, 2024

Screenshots/Videos

Uh oh!

OSBotify commented Jul 2, 2024

Uh oh!

OSBotify commented Jul 3, 2024

Uh oh!

OSBotify commented Jul 4, 2024

Uh oh!

OSBotify commented Jul 10, 2024

Uh oh!

OSBotify commented Jul 15, 2024

Uh oh!

linhvovan29546 Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

huult commented Jun 26, 2024 •

edited

Loading

github-actions bot commented Jun 26, 2024 •

edited

Loading

suneox commented Jun 28, 2024 •

edited

Loading