[No QA] Fix deploy comments if a deploy is cancelled in progress by roryabraham · Pull Request #44581 · Expensify/App

roryabraham · 2024-06-28T00:03:04Z

Details

Deploy comments do not appear to post successfully if the deploy is cancelled in progress (either manually or by another deploy being queued). This is because we look for the last completed deploy to determine which tags to use when listing out PRs that need deploy comments. However, status: 'completed' isn't enough because even workflow runs with conclusion: 'cancelled' will have status: completed.

So this PR looks for workflow runs that are not cancelled and have at least one successful Build and deploy job.

Fixed Issues

$ not sure if there's an issue for this

Tests

Merge this PR.
CP two PRs, one after the other.
Verify that after the 2nd triggered deploy completes, both CP'd PRs get deploy comments with the higher version number of the 2nd CP.

Verify that no errors appear in the JS console

Offline tests

None.

QA Steps

None.

Verify that no errors appear in the JS console

PR Author Checklist

Reviewer Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-06-28T00:03:32Z

@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham · 2024-06-28T00:26:23Z

.github/actions/javascript/getDeployPullRequestList/getDeployPullRequestList.ts

+        while (
+            lastSuccessfulDeploy &&
+            !(
+                await GithubUtils.octokit.actions.listJobsForWorkflowRun({


https://octokit.github.io/rest.js/v20#actions-list-jobs-for-workflow-run

Julesssss · 2024-06-28T10:26:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2024-06-28T10:39:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Julesssss · 2024-06-28T10:41:40Z

Discussing the testing plan here

OSBotify · 2024-07-03T20:02:48Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.4-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-04T22:15:15Z

🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T11:03:53Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T20:22:23Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

roryabraham added 3 commits June 27, 2024 16:36

Filter out cancelled workflow runs

6a1b2e7

Add code comment

c0f8c5f

Find the most recent deploy for which at least one build succeeded

3d35406

roryabraham self-assigned this Jun 28, 2024

roryabraham requested a review from a team as a code owner June 28, 2024 00:03

melvin-bot bot requested review from Julesssss and removed request for a team June 28, 2024 00:03

Fix lint

5532a67

roryabraham commented Jun 28, 2024

View reviewed changes

Julesssss approved these changes Jun 28, 2024

View reviewed changes

Julesssss merged commit 58a724e into main Jun 28, 2024

Julesssss deleted the Rory-FixDeployComments branch June 28, 2024 10:31

github-actions bot mentioned this pull request Jul 3, 2024

Deploy Checklist: New Expensify 2024-07-03 #44782

Closed

roryabraham mentioned this pull request Jul 25, 2024

[No QA] Correctly target last completed deploy #46244

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] Fix deploy comments if a deploy is cancelled in progress#44581

[No QA] Fix deploy comments if a deploy is cancelled in progress#44581
Julesssss merged 4 commits intomainfrom
Rory-FixDeployComments

roryabraham commented Jun 28, 2024 •

edited by github-actions bot

Loading

Uh oh!

melvin-bot bot commented Jun 28, 2024

Uh oh!

roryabraham Jun 28, 2024

Uh oh!

Julesssss commented Jun 28, 2024 •

edited

Loading

Uh oh!

OSBotify commented Jun 28, 2024

Uh oh!

Julesssss commented Jun 28, 2024

Uh oh!

OSBotify commented Jul 3, 2024

Uh oh!

OSBotify commented Jul 4, 2024

Uh oh!

OSBotify commented Jul 10, 2024

Uh oh!

OSBotify commented Jul 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

roryabraham commented Jun 28, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 28, 2024

Uh oh!

roryabraham Jun 28, 2024

Choose a reason for hiding this comment

Uh oh!

Julesssss commented Jun 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Jun 28, 2024

Uh oh!

Julesssss commented Jun 28, 2024

Uh oh!

OSBotify commented Jul 3, 2024

Uh oh!

OSBotify commented Jul 4, 2024

Uh oh!

OSBotify commented Jul 10, 2024

Uh oh!

OSBotify commented Jul 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

roryabraham commented Jun 28, 2024 •

edited by github-actions bot

Loading

Julesssss commented Jun 28, 2024 •

edited

Loading