Fix "New messages" banner shows up every time sending a message in a chat by bernhardoj · Pull Request #44724 · Expensify/App

bernhardoj · 2024-07-02T09:51:42Z

Details

Sending a message in a chat always shows the "New message" floating banner. This PR fix it.

Fixed Issues

$ #43486
PROPOSAL: #43486 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open a chat with long message history
Send a chat
Verify there is no "New messages" banner shows

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

…ew-message

melvin-bot · 2024-07-02T09:51:52Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2024-07-02T09:52:35Z

Note: If you can't send a message in mWeb, disable the strict mode

…ew-message

shubham1206agra · 2024-07-02T10:32:08Z

@bernhardoj Please fix tests.

bernhardoj · 2024-07-02T12:46:53Z

Still investigating

…ew-message

bernhardoj · 2024-07-03T14:28:29Z

Fixed the unit test. Reassure left. I will explain the fix after everything is fixed.

bernhardoj · 2024-07-04T09:43:11Z

src/components/PopoverMenu.tsx

-        setEnteredSubMenuIndexes([]);
+        setEnteredSubMenuIndexes(CONST.EMPTY_ARRAY);
        setCurrentMenuItems(menuItems);
    }, [menuItems]);


This fixes the reassure extra render count. This effect is run on mount and on menuItems prop update. enteredSubMenuIndexes initial value is [] and we update it to [] which has different references. Using CONST.EMPTY_ARRAY so it has stable references.

tests/ui/UnreadIndicatorsTest.tsx

bernhardoj · 2024-07-04T10:04:00Z

src/pages/home/report/ReportActionsList.tsx

-                Navigation.setParams({referrer: undefined});
+                if (isFromNotification) {
+                    Navigation.setParams({referrer: undefined});
+                }


This also fixes the test of UnreadIndicatorsTest. When the test runner opens the report screen, if it's unread (which is true), it will call both functions above to mark the report as read and remove the referrer param.

When the referrer param is updated, the report screen is re-mounted (on test only), but the readNewestAction optimisticData isn't completed yet and triggers the above logic again, repeatedly, infinitely.

This doesn't happen when we still use withOnyx, specifically the reportMetadata. Using withOnyx, when the report screen is re-mounted, it's not immediately rendered because reportMetadata has a pending merge, giving optimisticData of readNewestAction time to complete.

I think the best solution is to clear the referrer param after the readNewestAction optimisticData is applied, but I'm not sure how we can do that without using a timeout.

Given the re-mount behavior when updating param is only occurs on test, I updated the code to only clears it when referrer exists.

bernhardoj · 2024-07-04T10:33:48Z

We still have 1 issue left.

Open #admins room
Refresh
Crash because of

Based on the crash log and react docs, this is because we keep returning a different value from getSnapshot of useOnyx.

I think this happen after Expensify/react-native-onyx#551 where we do deepEqual comparison only if the key is a collection key and there is a selector, otherwise, it will just use shallowEqual. In our case, we do have a selector, but it's not a collection key and the selector always returns a new array reference.

App/src/pages/home/ReportScreen.tsx

Line 829 in a84f68e

    
           selector: (allReportActions: OnyxEntry<OnyxTypes.ReportActions>) => ReportActionsUtils.getSortedReportActionsForDisplay(allReportActions, true),

cc: @fabioh8010

fabioh8010 · 2024-07-04T10:42:56Z

@bernhardoj Thanks for the info, I'm going to take a look at Onyx!

fabioh8010 · 2024-07-04T17:11:40Z

@bernhardoj Here's the Onyx Draft PR. I will add tests tomorrow and open it for review.

…ew-message

bernhardoj · 2024-07-05T04:48:01Z

@fabioh8010 thanks! I tested it locally in this PR and it solves the issue.

fabioh8010 · 2024-07-05T15:52:53Z

@bernhardoj I opened the Onyx PR to review.

github-actions · 2024-07-15T16:37:40Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/44724/index.html
The QR code can't be generated, because the android build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/44724/NewExpensify.dmg	https://44724.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

youssef-lr · 2024-07-15T17:05:39Z

bump @shubham1206agra

shubham1206agra · 2024-07-15T17:06:58Z

@bernhardoj Can you merge the main once again please?

…ew-message

bernhardoj · 2024-07-16T02:24:50Z

Merged with main

shubham1206agra · 2024-07-16T18:31:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-07-16.at.11.41.04.PM.mov

iOS: Native

Screen.Recording.2024-07-16.at.11.56.24.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-07-16.at.11.34.51.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-16.at.11.15.37.PM.mov

MacOS: Desktop

Screen.Recording.2024-07-16.at.11.44.53.PM.mov

youssef-lr

LGTM and tested well in my account!

OSBotify · 2024-07-16T18:46:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-17T02:09:14Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.0.8-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-17T15:49:34Z

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.0.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

…ge-shows-every-time-add-new-message" This reverts commit 8d9b20b, reversing changes made to f83abb0.

[CP Staging] Revert "Merge pull request #44724 from bernhardoj/fix/43486-new-messge-shows-every-time-add-new-message

[CP Staging] Revert "Merge pull request #44724 from bernhardoj/fix/43486-new-messge-shows-every-time-add-new-message (cherry picked from commit 0560908)

OSBotify · 2024-07-18T13:50:23Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-18T14:12:30Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.0.9-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

…x/43486-new-message-shows-every-time-add-new-message"" This reverts commit 0a3604a.

OSBotify · 2024-07-19T11:55:11Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.9-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-23T08:02:31Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.10-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

bernhardoj added 3 commits June 22, 2024 12:03

replace withOnyx with useOnyx

eebf281

Merge branch 'main' into fix/43486-new-message-shows-every-time-add-n…

391e4f6

…ew-message

replace withOnyx with useOnyx hook

4e24f27

bernhardoj marked this pull request as ready for review July 2, 2024 09:51

bernhardoj requested a review from a team as a code owner July 2, 2024 09:51

melvin-bot bot requested review from shubham1206agra and removed request for a team July 2, 2024 09:51

bernhardoj added 2 commits July 2, 2024 18:25

reuse variable

57edf6c

Merge branch 'main' into fix/43486-new-message-shows-every-time-add-n…

fc6420e

…ew-message

bernhardoj added 4 commits July 3, 2024 19:37

Merge branch 'main' into fix/43486-new-message-shows-every-time-add-n…

2762037

…ew-message

update test

7a29255

only clears the referrer when it's open from notification

8c427a2

prettier

8acb474

bernhardoj added 2 commits July 4, 2024 17:11

fix extra render

1d6de85

prettier

f93774e

bernhardoj commented Jul 4, 2024

View reviewed changes

tests/ui/UnreadIndicatorsTest.tsx Outdated Show resolved Hide resolved

bernhardoj commented Jul 4, 2024

View reviewed changes

fabioh8010 mentioned this pull request Jul 4, 2024

Fix useOnyx equality check Expensify/react-native-onyx#566

Merged

42 tasks

Merge branch 'main' into fix/43486-new-message-shows-every-time-add-n…

d0fddfe

…ew-message

youssef-lr added the Ready To Build label Jul 15, 2024

Merge branch 'main' into fix/43486-new-message-shows-every-time-add-n…

c923fac

…ew-message

shubham1206agra approved these changes Jul 16, 2024

View reviewed changes

melvin-bot bot requested a review from youssef-lr July 16, 2024 18:32

youssef-lr approved these changes Jul 16, 2024

View reviewed changes

youssef-lr merged commit 8d9b20b into Expensify:main Jul 16, 2024

github-actions bot mentioned this pull request Jul 17, 2024

Deploy Checklist: New Expensify 2024-07-17 #45538

Closed

48 tasks

thienlnam mentioned this pull request Jul 17, 2024

Chat - Chat is auto scrolled up when opened for the first time #45634

Closed

6 tasks

allgandalf mentioned this pull request Jul 18, 2024

[HOLD for payment 2024-07-25] [$50] Login – Hmm… page opens when login with Google/Apple button or existing account #45657

Closed

6 tasks

mountiny added a commit that referenced this pull request Jul 18, 2024

Revert "Merge pull request #44724 from bernhardoj/fix/43486-new-messa…

0a3604a

…ge-shows-every-time-add-new-message" This reverts commit 8d9b20b, reversing changes made to f83abb0.

mountiny mentioned this pull request Jul 18, 2024

[CP Staging] Revert "Merge pull request #44724 from bernhardoj/fix/43486-new-messge-shows-every-time-add-new-message #45674

Merged

50 tasks

mountiny added a commit that referenced this pull request Jul 18, 2024

Merge pull request #45674 from Expensify/vit-revert44724

0560908

[CP Staging] Revert "Merge pull request #44724 from bernhardoj/fix/43486-new-messge-shows-every-time-add-new-message

OSBotify pushed a commit that referenced this pull request Jul 18, 2024

Merge pull request #45674 from Expensify/vit-revert44724

5fb3d25

[CP Staging] Revert "Merge pull request #44724 from bernhardoj/fix/43486-new-messge-shows-every-time-add-new-message (cherry picked from commit 0560908)

melvin-bot bot mentioned this pull request Jul 18, 2024

[HOLD for payment 2024-08-09] [$250] ‘New messages’ banner shows up every time for the sender when sending a message to a chat report #43486

Closed

6 tasks

github-actions bot mentioned this pull request Jul 18, 2024

Deploy Checklist: New Expensify 2024-07-18 #45680

Closed

61 tasks

bernhardoj added a commit to bernhardoj/Expensify that referenced this pull request Jul 18, 2024

Revert "Revert "Merge pull request Expensify#44724 from bernhardoj/fi…

4b0d0de

…x/43486-new-message-shows-every-time-add-new-message"" This reverts commit 0a3604a.

bernhardoj mentioned this pull request Jul 18, 2024

#2 - Fix new message shows every time add new message #45711

Merged

50 tasks

mollfpr mentioned this pull request Jul 24, 2024

[HOLD for payment 2024-07-26] [$250] Send invoice - "Choose a payment method" disappears after returning from Pay elsewhere page #44830

Closed

6 tasks

Conversation

bernhardoj commented Jul 2, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 2, 2024

Uh oh!

bernhardoj commented Jul 2, 2024

Uh oh!

shubham1206agra commented Jul 2, 2024

Uh oh!

bernhardoj commented Jul 2, 2024

Uh oh!

bernhardoj commented Jul 3, 2024

Uh oh!

bernhardoj Jul 4, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bernhardoj Jul 4, 2024

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Jul 4, 2024

Uh oh!

fabioh8010 commented Jul 4, 2024

Uh oh!

fabioh8010 commented Jul 4, 2024

Uh oh!

bernhardoj commented Jul 5, 2024

Uh oh!

fabioh8010 commented Jul 5, 2024

Uh oh!

github-actions bot commented Jul 15, 2024

Uh oh!

youssef-lr commented Jul 15, 2024

Uh oh!

shubham1206agra commented Jul 15, 2024

Uh oh!

bernhardoj commented Jul 16, 2024

Uh oh!

shubham1206agra commented Jul 16, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

youssef-lr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jul 16, 2024

Uh oh!

OSBotify commented Jul 17, 2024

Uh oh!

OSBotify commented Jul 17, 2024

Uh oh!

OSBotify commented Jul 18, 2024

Uh oh!

OSBotify commented Jul 18, 2024

Uh oh!

OSBotify commented Jul 19, 2024

Uh oh!

OSBotify commented Jul 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

youssef-lr left a comment •

edited

Loading