Skip to content

fix: iOS - Distance - Center icon overlaps with compass icon. #44752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lakchote merged 6 commits into from
Jul 17, 2024
Merged

fix: iOS - Distance - Center icon overlaps with compass icon. #44752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eb42657
fix: iOS - Distance - Center icon overlaps with compass icon.
Krishna2323 Jul 2, 2024
bd080ce
Merge branch 'Expensify:main' into krishna2323/issue/44486
Krishna2323 Jul 10, 2024
0b1602e
Merge branch 'Expensify:main' into krishna2323/issue/44486
Krishna2323 Jul 14, 2024
7010100
remove scale bar.
Krishna2323 Jul 14, 2024
d43f443
add comment.
Krishna2323 Jul 14, 2024
9b5c74d
minor update.
Krishna2323 Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/components/MapView/MapView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,10 @@ const MapView = forwardRef<MapViewHandle, ComponentProps>(
pitchEnabled={pitchEnabled}
attributionPosition={{...styles.r2, ...styles.b2}}
scaleBarEnabled={false}
// We use scaleBarPosition with top: -32 to hide the scale bar on iOS because scaleBarEnabled={false} not work on iOS
scaleBarPosition={{...styles.tn8, left: 0}}
compassEnabled
compassPosition={{...styles.l2, ...styles.t5}}
logoPosition={{...styles.l2, ...styles.b2}}
// eslint-disable-next-line react/jsx-props-no-spreading
{...responder.panHandlers}
Expand Down
3 changes: 3 additions & 0 deletions src/styles/utils/positioning.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ export default {
t0: {
top: 0,
},
t5: {
top: 20,
},
tn4: {
top: -16,
},
Expand Down