[CP Staging] Add back comment linking beta#44780
Merged
jasperhuangg merged 4 commits intomainfrom Jul 3, 2024
Merged
Conversation
tgolen
approved these changes
Jul 3, 2024
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
OSBotify
pushed a commit
that referenced
this pull request
Jul 3, 2024
Add back comment linking beta (cherry picked from commit 292d7b2)
48 tasks
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
jasperhuangg
added a commit
that referenced
this pull request
Jul 3, 2024
…ging-44780-1 🍒 Cherry pick PR #44780 to staging 🍒
85 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.0.3-7 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.0.4-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
A comment linking deploy blocker blocked NewDot deploy for 3 days, and we ended up deciding that it was more harmful for it to keep blocking deploy than it was to let it go through to production.
Since we're doing that we're sticking comment linking back behind a beta while that regression is figured out.
Fixed Issues
$ https://expensify.slack.com/archives/C07ASQ9GK1Q/p1720029257567129?thread_ts=1720021365.467379&cid=C07ASQ9GK1Q
Tests/QA
canUseAllBetastoreturn false;Offline tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop