chore: bump rn-live-markdown to 0.1.101

[hannojg]

Details

This PR bumps rn-live-markdown specifically for testing this change to fix the mentioned issue:

• fix: check if its first render before updating from props react-native-live-markdown#419

Note: This PR is primarily to test if the mentioned issue is resolved. There is another ongoing rn-live-markdown bump PR which should be merged first:

• Bump expensify-common and react-native-live-markdown #44262

Fixed Issues

$ #43983
PROPOSAL: #43983 (comment)
$ #44185

Tests

• Go to workspace chat
  • Submit expense
  • Scan a receipt
  • Click on Description row
  • Start typing quickly
• Open a chat where the keyboard will automatically be opened
  • Type quickly
  • Make sure nothing weird happens in the input (e.g. cursor position changing, typed letters being deleted etc)

Offline tests

n/a

QA Steps

• Same as testing

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

fixed.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[hannojg]

cc @mountiny

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/44913/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/44913/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/44913/NewExpensify.dmg	https://44913.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[BartoszGrajdek]

Hi! There's also another PR that bumps the version to 0.1.99 here. Not sure yet how we want to proceed here (we currently have 3 PRs bumping the version of react-native-live-markdown which is not ideal).

I'll get back to you, just adding the info here for now, to make sure we don't merge things in the wrong order.

[hannojg]

Maybe @mountiny you could confirm whether the issue is fixed on your end - once we confirmed it fixes the issue we could close this PR, and bump in this PR to 0.1.101 instead of 0.1.99?

[Skalakid]

@hannojg @mountiny we found a fix for a bug with double pasting text in E/App Composer. We have to make changes in both NewDot and library. I will create a PR with the fix and the bump to the latest version, okay?

[mountiny]

@hannojg yeah I have been testing it around and could not repro, I will test again

[mountiny]

@hannojg I have tried this couple of times and seems to work well 🎉

[mountiny]

In terms of bump, I feel like its safer to take smaller bumps to catch regressions easier so maybe you can make a bump after the one you have linked?

[Skalakid]

@mountiny In version 1.92 of the Live Markdown library we spotted a critical regression that makes the text to be pasted twice. Any library bump to the version above 1.92 will introduce a deploy blocker. Because of that, we decided to create a separate PR with the bump to the latest version and with the fix. I know it would be safer to make smaller bumps, however, I think we should avoid the situation when we introduce a critical bug that will stop the deployment.
How about closing this PR and merge this one

[mountiny]

@Skalakid Yeah it makes sense its just hard to manage with the previous bumps, happy to close this one