perf: remove `useLastAccessedReportID` hook and call `findLastAccessedReport` only when needed by kosmydel · Pull Request #44955 · Expensify/App

kosmydel · 2024-07-08T12:52:05Z

Details

We should calculate the lastAccessedReportID only when needed, that means only once, and only when route.params.reportID is empty (code). This value is used to determine which chat we should show to the user when the user accesses the website without reportID in the URL.

Fixed Issues

$ #44925
PROPOSAL: N/A

Tests

Note

When testing, sometimes the lastVisitedPath might be loaded and the findLastAccessedReport function might not be called. To avoid this, you can add return undefined; at the beggining of the NavigationRoot -> initialState function.

Web & mWeb:

Last accessed report

Remember the last accessed report
Remove the reportID from the URL (go to e.g. https://staging.new.expensify.com/).
Load the page and verify the correct report is displayed

New account

Create a new account
Verify the correct report is displayed

Leave room

Leave a room
Verify the correct report is opened

Other platforms

Log in to the account
Verify that the app works

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console
Tests from the above

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-07-08.at.15.19.52.mov

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web2.mov

MacOS: Desktop

melvin-bot · 2024-07-08T13:21:09Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2024-07-08T13:46:10Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/44955/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/44955/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/44955/NewExpensify.dmg	https://44955.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

roryabraham · 2024-07-08T14:29:51Z

src/hooks/useLastAccessedReportID.ts

+ * @param skip - Whether to skip the calculation of last accessed report ID
 */
-export default function useLastAccessedReportID(shouldOpenOnAdminRoom: boolean) {
+export default function useLastAccessedReportID(shouldOpenOnAdminRoom: boolean, skip: boolean) {


Rather than adding a skip boolean param in a hook, let's just call ReportUtils.findLastAccessedReport in a useEffect? The reason I suggest that is because when consuming a hook, I'd expect it to re-render the consuming component every time the return value changes, which wouldn't be the case here.

When I added this hook it was used in both AuthScreens and ReportScreen, but it looks like the usage in AuthScreens was removed sometime last week

Something like what @fabioh8010 suggested here, except removing the hook entirely in favor of just a useEffect

@roryabraham of course I can use the approach from this PR, but I need to ask @fabioh8010 if he is okay with that, as I would need to copy some of his code to this PR.

Sure @kosmydel please use everything you may need from my PR, I was exploring an improvement last week but didn't have time to go back to it.

Thank you @fabioh8010! I've added some of the changes from your PR.

ikevin127 · 2024-07-08T20:25:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari *

web.mov

MacOS: Desktop

ikevin127

LGTM, tests well in all cases and removed calling findLastAccessedReport when not needed 🚀

OSBotify · 2024-07-09T18:29:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-10T11:21:08Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.0.6-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T11:38:22Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.0.6-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2024-07-10T13:09:52Z

@mountiny the steps are similar to #44948. Can we check it off?

mountiny · 2024-07-10T15:05:16Z

@kavimuru I think so yes

…astAccessedReportID" This reverts commit 7bbb3fb, reversing changes made to bf785d9.

OSBotify · 2024-07-11T10:18:37Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-11T10:38:13Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-15T20:27:02Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-17T00:21:52Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

rayane-d · 2024-07-23T20:52:59Z

FYI, This caused this regression and was partially reverted in PR #45224 and then corrected in PR #45494. More details in #45494 (comment)

Calculate useLastAccessedReportID only when needed

23574ab

kosmydel force-pushed the fix-useLastAccessedReportID branch from 43db35d to 23574ab Compare July 8, 2024 12:52

blazejkustra approved these changes Jul 8, 2024

View reviewed changes

BrtqKr approved these changes Jul 8, 2024

View reviewed changes

mountiny assigned kosmydel Jul 8, 2024

mountiny added the Ready To Build label Jul 8, 2024

kosmydel marked this pull request as ready for review July 8, 2024 13:21

kosmydel requested a review from a team as a code owner July 8, 2024 13:21

melvin-bot bot requested review from ikevin127 and removed request for a team July 8, 2024 13:21

kosmydel changed the title ~~Calculate useLastAccessedReportID only when needed~~ perf: calculate useLastAccessedReportID only when needed Jul 8, 2024

roryabraham requested changes Jul 8, 2024

View reviewed changes

remove useLastAccessedReportID hook

fce4824

kosmydel changed the title ~~perf: calculate useLastAccessedReportID only when needed~~ perf: remove useLastAccessedReportID hook and call findLastAccessedReport only when needed Jul 8, 2024

kosmydel added 2 commits July 8, 2024 17:20

lint

9648424

fix performance tests

9c4741b

mountiny requested a review from roryabraham July 8, 2024 17:09

ikevin127 approved these changes Jul 9, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny July 9, 2024 00:03

fabioh8010 approved these changes Jul 9, 2024

View reviewed changes

roryabraham approved these changes Jul 9, 2024

View reviewed changes

roryabraham merged commit 7bbb3fb into Expensify:main Jul 9, 2024

github-actions bot mentioned this pull request Jul 10, 2024

Deploy Checklist: New Expensify 2024-07-10 #45144

Closed

francoisl added a commit that referenced this pull request Jul 10, 2024

Revert "Merge pull request #44955 from software-mansion-labs/fix-useL…

3dd9e54

…astAccessedReportID" This reverts commit 7bbb3fb, reversing changes made to bf785d9.

This was referenced Jul 10, 2024

[PAID] Workspace - Endless skeleton loader after login if the account is added to a workspace #45212

Closed

[CP Staging] Fix default chat report view not loading upon signin #45224

Merged

ikevin127 mentioned this pull request Jul 15, 2024

[HOLD for Payment 2024-07-22] [$250] Improve ReportScreen rendering time #44925

Closed

BrtqKr mentioned this pull request Jul 16, 2024

Optimize last accessed report calculation #45494

Merged

50 tasks

bernhardoj mentioned this pull request Jul 18, 2024

[HOLD for payment 2024-08-09] [$250] ‘New messages’ banner shows up every time for the sender when sending a message to a chat report #43486

Closed

6 tasks

Conversation

kosmydel commented Jul 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Web & mWeb:

Other platforms

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 8, 2024

Uh oh!

github-actions bot commented Jul 8, 2024

Uh oh!

roryabraham Jul 8, 2024

Choose a reason for hiding this comment

Uh oh!

roryabraham Jul 8, 2024

Choose a reason for hiding this comment

Uh oh!

kosmydel Jul 8, 2024

Choose a reason for hiding this comment

Uh oh!

fabioh8010 Jul 8, 2024

Choose a reason for hiding this comment

Uh oh!

kosmydel Jul 8, 2024

Choose a reason for hiding this comment

Uh oh!

ikevin127 commented Jul 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ikevin127 left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jul 9, 2024

Uh oh!

OSBotify commented Jul 10, 2024

Uh oh!

OSBotify commented Jul 10, 2024

Uh oh!

kavimuru commented Jul 10, 2024

Uh oh!

mountiny commented Jul 10, 2024

Uh oh!

OSBotify commented Jul 11, 2024

Uh oh!

OSBotify commented Jul 11, 2024

Uh oh!

OSBotify commented Jul 15, 2024

Uh oh!

OSBotify commented Jul 17, 2024

Uh oh!

rayane-d commented Jul 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

kosmydel commented Jul 8, 2024 •

edited

Loading

ikevin127 commented Jul 8, 2024 •

edited

Loading