Using setState to update state by cretadn22 · Pull Request #45178 · Expensify/App

cretadn22 · 2024-07-10T15:39:25Z

Details

Fixed Issues

$ #44830
PROPOSAL: #44830 (comment)

Tests

[User A] Send an invoice to user B.
[User B] Go to invoice chat.
[User B] Click Pay button.
[User B] Click Pay as individual
[User B] Click on the back button
"Choose a payment method below" in the payment method selection page will persist

Verify that no errors appear in the JS console

Offline tests

QA Steps

[User A] Send an invoice to user B.
[User B] Go to invoice chat.
[User B] Click Pay button.
[User B] Click Pay as individual
[User B] Click on the back button
"Choose a payment method below" in the payment method selection page will persist

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-13.at.15.54.48.mov

Android: mWeb Chrome

Screen.Recording.2024-07-10.at.22.38.57.mov

iOS: Native

Screen.Recording.2024-07-13.at.15.49.16.mov

iOS: mWeb Safari

Screen.Recording.2024-07-10.at.22.38.29.mov

MacOS: Chrome / Safari

web21.mov

MacOS: Desktop

Screen.Recording.2024-07-10.at.22.34.20.mov

melvin-bot · 2024-07-10T15:39:30Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cretadn22 · 2024-07-10T17:32:42Z

@mollfpr Can't test on IOS and Android due to an issue on the main branch

error.mov

mollfpr · 2024-07-11T15:15:17Z

Yeah, I can reproduce the issue on main too. Let's wait for the fix, we need to make sure that it works on all platforms.

cretadn22 · 2024-07-12T16:21:11Z

Updated comment

@mollfpr Since this bug is outside the current scope, should I create a new PR to address it or handle it here?

Problem and Solution

App/src/components/PopoverMenu.tsx

Line 218 in ec19663

    
           {!!headerText && enteredSubMenuIndexes.length === 0 && <Text style={[styles.createMenuHeaderText, styles.ph5, styles.pv3]}>{headerText}</Text>}

When headerText is undefined, rendering !!undefined will crash the app.

We need to implement a renderHeaderText function, similar to how we created the renderBackButtonItem function.

cretadn22 · 2024-07-13T09:19:06Z

@mollfpr I pushed a commit to fix the crash bug, you can test it now.

mollfpr · 2024-07-15T19:26:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

45178.Android.mp4

Android: mWeb Chrome

45178.mWeb-Chrome.mp4

iOS: Native

45178.iOS.mov

iOS: mWeb Safari

45178.mWeb-Safari.mov

MacOS: Chrome / Safari

45178.Web.mp4

MacOS: Desktop

45178.Desktop.mp4

mollfpr

LGTM!

techievivek · 2024-07-17T04:23:17Z

Oops, sorry for the delay, @cretadn22 can you please fix the conflicts? I can review if after that.

cretadn22 · 2024-07-17T12:51:35Z

@techievivek I handled conflict

techievivek

Thanks.

cretadn22 · 2024-07-17T12:56:36Z

@techievivek Wait me some minutes 😄

cretadn22 · 2024-07-17T13:12:11Z

@techievivek It's ok

OSBotify · 2024-07-17T13:29:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-18T14:12:51Z

🚀 Deployed to staging by https://github.com/techievivek in version: 9.0.9-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-19T11:55:32Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.9-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-19T19:36:47Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.9-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-23T08:03:04Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.10-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

update state correctly

50798ab

cretadn22 requested a review from a team as a code owner July 10, 2024 15:39

melvin-bot bot requested review from mollfpr and removed request for a team July 10, 2024 15:39

fix errors

9676f60

render header text

06faee8

mollfpr approved these changes Jul 15, 2024

View reviewed changes

melvin-bot bot requested a review from techievivek July 15, 2024 19:29

techievivek assigned cretadn22 Jul 17, 2024

handle conflict

0b777f1

techievivek previously approved these changes Jul 17, 2024

View reviewed changes

handle conflict

cff0655

cretadn22 dismissed techievivek’s stale review via cff0655 July 17, 2024 12:54

handle conflict

b4a4023

techievivek approved these changes Jul 17, 2024

View reviewed changes

techievivek merged commit 5ca9922 into Expensify:main Jul 17, 2024

github-actions bot mentioned this pull request Jul 18, 2024

Deploy Checklist: New Expensify 2024-07-18 #45680

Closed

61 tasks

melvin-bot bot mentioned this pull request Jul 19, 2024

[HOLD for payment 2024-07-26] [$250] Send invoice - "Choose a payment method" disappears after returning from Pay elsewhere page #44830

Closed

6 tasks

Conversation

cretadn22 commented Jul 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 10, 2024

Uh oh!

cretadn22 commented Jul 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mollfpr commented Jul 11, 2024

Uh oh!

cretadn22 commented Jul 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Updated comment

Problem and Solution

Uh oh!

cretadn22 commented Jul 13, 2024

Uh oh!

mollfpr commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

techievivek commented Jul 17, 2024

Uh oh!

cretadn22 commented Jul 17, 2024

Uh oh!

techievivek left a comment

Choose a reason for hiding this comment

Uh oh!

cretadn22 commented Jul 17, 2024

Uh oh!

cretadn22 commented Jul 17, 2024

Uh oh!

OSBotify commented Jul 17, 2024

Uh oh!

OSBotify commented Jul 18, 2024

Uh oh!

OSBotify commented Jul 19, 2024

Uh oh!

OSBotify commented Jul 19, 2024

Uh oh!

OSBotify commented Jul 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cretadn22 commented Jul 10, 2024 •

edited

Loading

cretadn22 commented Jul 10, 2024 •

edited

Loading

cretadn22 commented Jul 12, 2024 •

edited

Loading

mollfpr commented Jul 15, 2024 •

edited

Loading