[No QA] Fix missing parts of react-native-community/netinfo patch#45389
Conversation
Julesssss
left a comment
There was a problem hiding this comment.
Great find. I'll run the test build workflow against this PR now 👍
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@Julesssss @staszekscp Tested locally and both ios and android builds pass with these changes |
|
Ignoring failed checks:
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…-build [No QA] Fix missing parts of react-native-community/netinfo patch (cherry picked from commit 24c11b4)
…g-45389-1 🍒 Cherry pick PR #45389 to staging 🍒
|
Cherry pick in progress, this is expected to fail as the changes need to hit prod |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.6-6 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-8 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-8 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀
|
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.7-3 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀
|
Details
Ios builds were broken because of missing
codeGenblock inside@react-native-community/netinfo.The section was removed in this PR: #44901 by mistake I believe.
This PR modifies the patch and re-adds the missing
codeGenblockFixed Issues
$ #45392
Tests
Make sure ios build passes
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop