Skip to content

fix-45503: update trial copy issues #45527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chiragsalian merged 3 commits into from
Jul 17, 2024
Merged

fix-45503: update trial copy issues #45527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bec38b6
update subscription issues
allroundexperts Jul 16, 2024
5869792
remove unused var
allroundexperts Jul 16, 2024
9ebd971
handle comments
allroundexperts Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/pages/settings/Subscription/CardSection/BillingBanner/TrialEndedBillingBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
import React from 'react';
import * as Illustrations from '@components/Icon/Illustrations';
import useLocalize from '@hooks/useLocalize';
import * as SubscriptionUtils from '@libs/SubscriptionUtils';
import BillingBanner from './BillingBanner';

function TrialEndedBillingBanner() {
const {translate} = useLocalize();

if (SubscriptionUtils.doesUserHavePaymentCardAdded()) {
return null;
}

return (
<BillingBanner
title={translate('subscription.billingBanner.trialEnded.title')}
Expand Down
4 changes: 3 additions & 1 deletion src/pages/settings/Subscription/CardSection/BillingBanner/TrialStartedBillingBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@ import BillingBanner from './BillingBanner';
function TrialStartedBillingBanner() {
const {translate} = useLocalize();

const subtitle = !SubscriptionUtils.doesUserHavePaymentCardAdded() ? translate('subscription.billingBanner.trialStarted.subtitle') : '';

return (
<BillingBanner
title={translate('subscription.billingBanner.trialStarted.title', {numOfDays: SubscriptionUtils.calculateRemainingFreeTrialDays()})}
subtitle={translate('subscription.billingBanner.trialStarted.subtitle')}
subtitle={subtitle}
icon={Illustrations.TreasureChest}
/>
);
Expand Down