Fix auto reporting toggle by roryabraham · Pull Request #45540 · Expensify/App

roryabraham · 2024-07-17T00:15:34Z

Details

Best details found in:

Fixed Issues

$ #43196

Tests / QA Steps

(Expensify engineers using the dev API), checkout this Web-E branch if the PR is not merged yet.
Create a workspace
Go to workspace settings, click more features, and enable workflows
Go to workflows and toggle delay submissions
Switch the reporting frequency to Daily. Verify that it works and shows Daily
Switch the reporting frequency to Manually. Verify that it works and shows Manually.

Verify that no errors appear in the JS console

Offline tests

Repeat the steps offline.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

…ic data

melvin-bot · 2024-07-17T02:02:29Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham · 2024-07-17T02:03:27Z

@Beamanator tagging you as the author of instant submit doc, and @mountiny you as this pertains to next steps

src/libs/actions/Policy/Policy.ts

dukenv0307 · 2024-07-17T03:44:08Z

Codes look good, just have a comment above ^

roryabraham · 2024-07-17T06:31:23Z

Updated, improved comments, and added some TS enforcement that manual does not belong as an auto-reporting frequency in Onyx.

dukenv0307 · 2024-07-17T08:33:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-17.at.15.43.46.mov

Android: mWeb Chrome

Screen.Recording.2024-07-17.at.15.41.46.mov

iOS: Native

Screen.Recording.2024-07-17.at.15.44.00.mov

iOS: mWeb Safari

Screen.Recording.2024-07-17.at.15.41.14.mov

MacOS: Chrome / Safari

web-resize.mp4

MacOS: Desktop

Screen.Recording.2024-07-17.at.15.44.27.mov

dukenv0307 · 2024-07-17T08:46:00Z

LGTM

melvin-bot · 2024-07-17T08:47:08Z

@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Beamanator

Huh this is really annoying that we have some auto reporting frequencies that actually don't exist in the DB or Onyx? 🙃 that sounds like a high potential for future confusion from other people :///

src/libs/PolicyUtils.ts

src/libs/actions/Policy/Policy.ts

roryabraham · 2024-07-17T16:51:23Z

that sounds like a high potential for future confusion from other people

That's why I used TypeScript to prevent you saving it in Onyx, and left code comments all over the place 🙂

roryabraham · 2024-07-17T16:54:37Z

@Beamanator updated ✅

Beamanator

Thank you sir! And thanks for the comments 🙏

OSBotify · 2024-07-17T17:21:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-18T14:13:36Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.0.9-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-19T11:56:17Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.9-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-19T19:38:28Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.9-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-23T08:04:31Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.10-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

roryabraham added 2 commits July 16, 2024 17:02

Fix isActive for the DelaySubmissions toggle

c86a01b

Fix display for manual frequency

d3fface

roryabraham mentioned this pull request Jul 17, 2024

[HOLD for payment 2024-07-26] [$250] Workspace - "Delay submissions" turns off if the "Submission frequency" is set to "Manually" #43196

Closed

6 tasks

Improve comment

9b40a16

roryabraham self-assigned this Jul 17, 2024

roryabraham added 5 commits July 16, 2024 18:40

Fix display issue in list

883e672

Fix autoReportingFrequency in setWorkspaceAutoReportingFrequency

4f73784

Fix upgradeToCorporate

4ac8590

Account for harvesting in setWorkspaceAutoReportingFrequency optimist…

d49ad9a

…ic data

Fix initial focus

8b11572

roryabraham changed the title ~~[WIP] Fix auto reporting toggle~~ Fix auto reporting toggle Jul 17, 2024

roryabraham marked this pull request as ready for review July 17, 2024 02:02

roryabraham requested a review from a team as a code owner July 17, 2024 02:02

melvin-bot bot requested review from dukenv0307 and removed request for a team July 17, 2024 02:02

roryabraham requested a review from Beamanator July 17, 2024 02:03

roryabraham requested a review from mountiny July 17, 2024 02:03

roryabraham added 2 commits July 16, 2024 19:04

clarify comment

c9143de

clarify another comment

4aa4ea8

dukenv0307 reviewed Jul 17, 2024

View reviewed changes

src/libs/actions/Policy/Policy.ts Show resolved Hide resolved

roryabraham added 3 commits July 16, 2024 23:06

Re-enable harvesting if manual reporting is changed to auto reporting

f5b529e

Use types to prevent manual from being saved in Onyx

ac5770e

Improve comments

11e86ed

roryabraham requested a review from dukenv0307 July 17, 2024 06:29

dukenv0307 approved these changes Jul 17, 2024

View reviewed changes

melvin-bot bot requested a review from madmax330 July 17, 2024 08:47

Beamanator previously approved these changes Jul 17, 2024

View reviewed changes

src/libs/PolicyUtils.ts Outdated Show resolved Hide resolved

src/libs/actions/Policy/Policy.ts Outdated Show resolved Hide resolved

src/libs/actions/Policy/Policy.ts Outdated Show resolved Hide resolved

comment and variable name improvement

ad6cbeb

roryabraham dismissed Beamanator’s stale review via ad6cbeb July 17, 2024 16:54

roryabraham requested a review from Beamanator July 17, 2024 16:54

Beamanator approved these changes Jul 17, 2024

View reviewed changes

Beamanator merged commit ebe7d58 into main Jul 17, 2024

Beamanator deleted the Rory-FixAutoReportingToggle branch July 17, 2024 17:10

github-actions bot mentioned this pull request Jul 18, 2024

Deploy Checklist: New Expensify 2024-07-18 #45680

Closed

61 tasks

Conversation

roryabraham commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests / QA Steps

Offline tests

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 17, 2024

Uh oh!

roryabraham commented Jul 17, 2024

Uh oh!

Uh oh!

dukenv0307 commented Jul 17, 2024

Uh oh!

roryabraham commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Jul 17, 2024

Uh oh!

melvin-bot bot commented Jul 17, 2024

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

roryabraham commented Jul 17, 2024

Uh oh!

roryabraham commented Jul 17, 2024

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jul 17, 2024

Uh oh!

OSBotify commented Jul 18, 2024

Uh oh!

OSBotify commented Jul 19, 2024

Uh oh!

OSBotify commented Jul 19, 2024

Uh oh!

OSBotify commented Jul 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

roryabraham commented Jul 17, 2024 •

edited

Loading

roryabraham commented Jul 17, 2024 •

edited

Loading

dukenv0307 commented Jul 17, 2024 •

edited

Loading