Skip to content

Remove unnecessary withOnyx from chat messages#4573

Merged
nkuoch merged 1 commit intomainfrom
marcaaron-withCurrentDate
Aug 11, 2021
Merged

Remove unnecessary withOnyx from chat messages#4573
nkuoch merged 1 commit intomainfrom
marcaaron-withCurrentDate

Conversation

@marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Aug 11, 2021 •
edited
Loading

Details

Missed this when creating the context provider - there is an additional withOnyx() getting connected to each chat message slowing down chat rendering. There is more context about this in the original PR that added the OnyxProvider here -> #4348

cc @kidroca

Fixed Issues (Related To)

#4022

Tests

QA Steps

  1. No specific tests. Make sure chats load normally.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron requested a review from a team as a code owner August 11, 2021 17:50
@marcaaron marcaaron self-assigned this Aug 11, 2021
@MelvinBot MelvinBot requested review from nkuoch and removed request for a team August 11, 2021 17:50
@marcaaron marcaaron mentioned this pull request Aug 11, 2021
Closed
@nkuoch nkuoch merged commit 0448b00 into main Aug 11, 2021
@nkuoch nkuoch deleted the marcaaron-withCurrentDate branch August 11, 2021 20:17
@OSBotify
Copy link
Contributor

OSBotify commented Aug 11, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

This was referenced Aug 12, 2021
Closed
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Aug 17, 2021

🚀 Deployed to staging by @nkuoch in version: 1.0.85-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

kidroca
kidroca reviewed Aug 17, 2021
View reviewed changes
src/pages/home/report/ReportActionItemDate.js
currentDate: {
key: ONYXKEYS.CURRENT_DATE,
},
}),
Copy link
Contributor

@kidroca kidroca Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @marcaaron I've noticed this component does not use the date received from Onyx at all
Is this something we're passing to force a re-render?

Copy link
Contributor Author

@marcaaron marcaaron Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm that's a good question. I didn't look into the original intention behind why this subscription was added. Maybe we can look at the git blame to find out more.

Copy link
Contributor Author

@marcaaron marcaaron Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original PR is here -> https://github.com/Expensify/App/pull/3573/files

I think the intention is to force a re-render.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 25, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nkuoch nkuoch nkuoch approved these changes

+1 more reviewer

@kidroca kidroca kidroca left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@marcaaron marcaaron

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marcaaron @OSBotify @nkuoch @kidroca