Skip to content

fix: dismiss modal after deleting task #46272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thienlnam merged 1 commit into from
Aug 5, 2024
Merged

fix: dismiss modal after deleting task #46272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/actions/Task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1056,7 +1056,7 @@ function deleteTask(report: OnyxEntry<OnyxTypes.Report>) {
Report.notifyNewAction(report.reportID, currentUserAccountID);

if (shouldDeleteTaskReport) {
Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(parentReport?.reportID ?? '-1'));
return ROUTES.REPORT_WITH_ID.getRoute(parentReport?.reportID ?? '-1');
}
}

Expand Down
10 changes: 8 additions & 2 deletions src/pages/ReportDetailsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,8 +673,7 @@ function ReportDetailsPage({policies, report, session, personalDetails}: ReportD
setIsDeleteModalVisible(false);

if (caseID === CASES.DEFAULT) {
Task.deleteTask(report);
navigateBackToAfterDelete.current = undefined;
navigateBackToAfterDelete.current = Task.deleteTask(report);
return;
}

Expand Down Expand Up @@ -777,6 +776,13 @@ function ReportDetailsPage({policies, report, session, personalDetails}: ReportD
onModalHide={() => {
// We use isTransactionDeleted to know if the modal hides because the user deletes the transaction.
if (!isTransactionDeleted.current) {
if (caseID === CASES.DEFAULT) {
if (navigateBackToAfterDelete.current) {
Navigation.goBack(navigateBackToAfterDelete.current);
} else {
Navigation.dismissModal();
}
}
return;
}

Expand Down